feat(ui): inline large bar title on iPhone tab roots - #1204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ToolbarItem(placement: .largeTitle)+.toolbarTitleDisplayMode(.inlineLarge), gated to iOS 26+. The system hides the title on scroll down and restores it at the top by itself; the bar buttons stay put, and the bar background plus the top scroll-edge effect stay hidden so only the floating buttons remain. No system navigation title is set, so no collapsed bar title ever appears.ToolbarSpaceron iOS 26+ (on earlier iOS versions it also moves trailing, just without the spacer). Placement is unchanged elsewhere: leading (.cancellationAction) on iPad,.navigationon macOS.tab.homelocalization key; macOS window title unchanged).Why
The tab roots had no visible title on iPhone, and the library picker sat inside the trailing menu capsule. A leading large title gives each tab a clear identity in the bar row without spending content space on an in-content header, and the picker reads as its own control next to the menu.
Validation
make buildgreen on iOS, macOS, tvOS.make localize/translate.py list: no missing keys after removingtab.home.Includes
make bumpto build 624.