docs(server): cross-origin hosting works via cors.allowed-origins - #15
Merged
Merged
Conversation
KMServer now applies the configured origins as actual CORS headers (kmworks/kmrs#131), so the note claiming cross-origin hosting is unsupported is stale. Document that the wildcard is rejected because credentialed requests are always allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
server/webuinotes claimed cross-origin hosting is not supported because KMServer parsedKOMGA_CORS_ALLOWEDORIGINSwithout applying CORS headers. That gap is fixed in kmworks/kmrs#131, so the note is stale.How
Reword the bullet: cross-origin hosting works once the UI's origin is listed in
cors.allowed-origins, and the wildcard*is rejected because credentialed requests are always allowed.Testing
pnpm typecheck && pnpm exec nimbus-docs check && pnpm lint:docs && pnpm buildall pass locally.