Add share-by-link functionality and fix privacy hash consistency - #31
Merged
Conversation
X-Underlay-Record-Count reported the version's full recordCount while the ndjson stream is privacy-filtered and ?type=-scoped, so the documented "count the lines and resume if they differ" check never terminated for a non-owner reading a collection with private content — and was wrong for owners using ?type= too. Count what this request will actually emit. The /versions list was the one version endpoint not applying sanitizeVersionForPublic, so it returned actorId to non-owners while latest/:n stripped it. Docs: - normalize version hashes to the private:/public: prefix they carry, and drop the spurious sha256: prefix from record/schema/file hashes, which are bare hex on the wire - complete the error tables (401, 403, 413, 503; 409 covers both version conflict and duplicate-content) and state the 404-not-403 policy - document ?token= (GET/HEAD only, falls through to anonymous when invalid) and the read-only POST exception for files/presign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.