Repository navigation
Conversation
- 'software=Udio' in an OGG Vorbis comment was missed: the value boundary is '=' before and a binary length or framing byte after, not \x00/quote/<. Udio/Suno exact-value patterns now accept '=' before and any control byte after. - _parse_riff scanned the WAV 'data' chunk (PCM samples) with every signature regex: ~0.7 s per MB, 69 s for a 90 MB master, and only chance matches. Sample/frame chunks (data, VP8, VP8L, ALPH, ANMF, idx1, LIST movi) are skipped. Real files: OGG with Udio metadata 0/4 -> 4/4; MP3/WAV unchanged; 24 human recordings: 0 false positives before and after.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in the media watermark detector (found on PromoPilot's audio-watermark-detector).
software=Udioin an OGG file was missed: the value sits between=and the next field's binary length (or the framing byte\x01), and the exact-value patterns for Udio/Suno only accepted\x00, quotes and</>. Now=is accepted before and any control byte after; "title=Udio Studio take" still does not match._parse_riffran every signature regex over thedatachunk (PCM samples): ~0.7 s per MB, 69 s for a 90 MB master, and only chance matches. Sample/frame chunks (data,VP8,VP8L,ALPH,ANMF,idx1,LIST movi) are skipped; metadata chunks are scanned as before.Tests: two new cases, both fail on main and pass here (17 passed). Real files on PromoPilot: OGG with Udio metadata 0/4 → 4/4, MP3 and WAV unchanged, 24 human recordings 0 false positives before and after, 90 MB WAV 69 s → 0.04 s.