Repository navigation
Drop null overrides of chart defaults in MergeValues - #151
Open
ArnobKumarSaha wants to merge 1 commit into
Open
ArnobKumarSaha wants to merge 1 commit into
ArnobKumarSaha wants to merge 1 commit into
Conversation
MergeValues merges chart defaults with user values itself and callers blank chart.Values, so Helm's coalesce never removes keys set to null. The nulls then reach JSON schema validation (e.g. 'got null, want integer'). Delete null overrides of chart defaults, as the helm CLI does. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MergeValuesmerges the chart's values.yaml with user values itself, and install/upgrade/template then setchrt.Values = {}before calling Helm. Helm only deletes akey=nulloverride when the key exists inchart.Values(chartutil/coalesce.go), so the null survives and fails JSON schema validation:This deletes null overrides of keys present in the chart defaults, matching the helm CLI. Nulls for keys absent from the defaults are kept, as Helm does. The
ReplaceValuesandValuesPatchpaths are unchanged.