Skip to content

fix: removing Thread.sleep() from KubernetesReconcilerCreatorTest - #4915

Open
sarveshkaushal wants to merge 1 commit into
kubernetes-client:masterfrom
sarveshkaushal:sarveshkaushal/flaky-test-k8reconciler-clean
Open

sarveshkaushal wants to merge 1 commit into
kubernetes-client:masterfrom
sarveshkaushal:sarveshkaushal/flaky-test-k8reconciler-clean

Conversation

@sarveshkaushal

@sarveshkaushal sarveshkaushal commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Notes

Replaces the fixed Thread.sleep() in KubernetesReconcilerCreatorTest with semaphore based synchronization.

The custom work-queue key function releases a semaphore after adding the generated request to the controller work queue. The test waits for that signal before asserting on the queue.

This is related to issue #1223

Testing

Ran mvn install on the project root.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sarveshkaushal
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sarveshkaushal

Copy link
Copy Markdown
Contributor Author

/assign @brendandburns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants