Skip to content

Fix pod memory request aggregation - #3033

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:mainfrom
brendandburns:fix-top-memory-request-aggregation
Sep 1, 2026
Merged

Fix pod memory request aggregation#3033
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:mainfrom
brendandburns:fix-top-memory-request-aggregation

Conversation

@brendandburns

Copy link
Copy Markdown
Contributor

Summary

  • accumulate each container's memory request from the pod request total rather than the pod limit total
  • add regression coverage using multiple containers with distinct memory requests and limits

This addresses the pod memory-request aggregation correctness gap identified in the client-go gap analysis.

Testing

  • npm run build
  • node --test --test-reporter=spec --import tsx src/top_test.ts
  • repository push hooks

@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2026

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, cjihrig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,cjihrig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot merged commit b05d6e5 into kubernetes-client:main Sep 1, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants