Add audience-specific Where builds - #174
Open
kyleve wants to merge 1 commit into
Open
Conversation
Define Development, Beta, and App Store schemes with host-only compiler conditions and injected audience configuration. Isolate development persistence, make primary icons audience-aware, and protect configured primaries in the icon tooling.
kyleve
commented
Aug 2, 2026
| require_repo_layout() | ||
| with open(PROJECT_MANIFEST) as f: | ||
| source = f.read() | ||
| names = set(re.findall(r'primaryAppIconName:\s*"([^"]+)"', source)) |
Owner
Author
There was a problem hiding this comment.
Posted by an AI agent on kyleve's behalf.
Review focus: this intentionally reads the literal primaryAppIconName fields from Project.swift so audience primaries retain one source of truth. It fails closed if that descriptor shape stops yielding any names; the regression fixture also verifies a non-base configured primary cannot be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./iconsfrom deleting any asset currently configured as an audience primaryDesign notes
Audience metadata remains centralized in
Project.swift. The icon tool reads those descriptors when guarding removal, so it does not introduce a second primary-icon configuration. Enterprise distribution remains intentionally out of scope.Validation
mise exec -- tuist build "Where Development"mise exec -- tuist build "Where Beta"mise exec -- tuist build "Where App Store"./test --all— 1,626 tests passed./swiftformat --lintbash -n iconsandbash -n Where/install./icons --remove, with catalogs and manifest unchanged