Fix: align and fix toasts - #937
Merged
Merged
Conversation
Ph4t3
marked this pull request as draft
September 8, 2026 16:22
Ph4t3
marked this pull request as ready for review
September 8, 2026 19:59
timbastin
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes l3montree-dev/devguard#3026
Toasts on multiple pages did not work due to direct import from sonner instead of lib/toast.
All these were fixed and tested to work properly now.
For example some components on the org dashboard now actually display their toasts correctly like this.
In user settings, this also led to Ory overwriting the toast in it's own default style, making it display always in light mode and on the bottom right of the screen.
To make the toast messages more consistent, and also specific to the individual action that made them display, a new helper
justificationValidator.tswas introduced instead of copying the same logic into every single component.Toasts now specify if a comment or justification is missing for a comment, mitigation decision or ticket creation.
To-do:
Fixes for new lint rules