Add missing model SVG logos - #25
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ The catalog validates: 46 hardware, 31 models, 14 quants, 7 runtimes. The entry shows up on the site with the next deploy. Format notes are in frontend/src/catalog/README.md. |
No result files to import. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Nine catalog models currently display monograms because their logo paths are missing. Add seven shared SVGs for GLM, GPT-OSS, Granite, Liquid, MiniCPM, Mistral, and Nemotron, and connect them to the catalog so all 31 models have logos.
Six marks come from the existing LobeHub SVG package; MiniCPM uses the symbol from ModelBest's official SVG. Document the sources and adaptations, including explicit colors for monochrome marks rendered through image elements.
This is a frontend-only change. The application reads logo paths from the local catalog even in Supabase mode, so no database migration is required.
Checks
npm --prefix frontend run typecheckpassesnpm --prefix frontend run catalog:validatepasses (the sandbox logged a Vite WebSocket bind warning)git diff --checkpasses