Repository navigation
fix(service): rewrite a service plist that collects into another data directory - #89
Merged
Merged
Conversation
… directory The service takes DRIGA_DATA_DIR from the environment that installs it. A plist that recorded another directory, such as one with an escaped space, was never repaired: install only rewrote the plist when its executable or bundle association changed, so the app's launch-time install kept it, and every client fell back to snapshot mode with no reason given. PlistStale now also reports a plist whose data directory differs from the one this process uses, an unset value meaning the default. Install rewrites it and logs service_data_dir_moved with both directories, and doctor's service_definition warning names the cause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service takes DRIGA_DATA_DIR from the environment that installs it. A
plist that recorded another directory, such as one with an escaped space,
was never repaired: install only rewrote the plist when its executable or
bundle association changed, so the app's launch-time install kept it, and
every client fell back to snapshot mode with no reason given.
PlistStale now also reports a plist whose data directory differs from the
one this process uses, an unset value meaning the default. Install rewrites
it and logs service_data_dir_moved with both directories, and doctor's
service_definition warning names the cause.