Repository navigation
fix(mcp): tell the agent where run_command runs - #91
Merged
Merged
Conversation
Commands run with HOME and TMPDIR in Chat's private scratch directory and a PATH of system directories only, but the tool description said neither. The agent read the results as if they came from the user's shell: go clean -modcache reported success after clearing an empty cache in scratch, and npm failed with exit code 127 without the agent knowing why. The description now states HOME, TMPDIR and PATH, asks for full paths to other programs, and says writes outside the project and scratch are refused.
Address review: the scratch home starts empty, and Homebrew programs such as npm start node through /usr/bin/env, so a full path alone fails; set PATH in a script instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands run with HOME and TMPDIR in Chat's private scratch directory and a
PATH of system directories only, but the tool description said neither. The
agent read the results as if they came from the user's shell: go clean
-modcache reported success after clearing an empty cache in scratch, and npm
failed with exit code 127 without the agent knowing why.
The description now states HOME, TMPDIR and PATH, asks for full paths to
other programs, and says writes outside the project and scratch are refused.