Repository navigation
fix(release): pass the service environment to the cask's install verbatim - #93
Merged
Merged
Conversation
…atim The Homebrew cask's postflight re-ran driga service install with the old plist's environment through system_command's env: option. Homebrew shell-escapes env: values but runs no shell, so DRIGA_DATA_DIR became "/Users/me/Library/Application\ Support/driga" with a literal backslash. Every upgrade then installed a service collecting into a stray directory, and the app and CLI fell back to snapshot mode. The postflight now runs /usr/bin/env with the assignments as arguments, which Homebrew passes unchanged. The cask test uses a data directory with a space, and the release check requires the new form and rejects env:.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Homebrew cask's postflight re-ran driga service install with the old
plist's environment through system_command's env: option. Homebrew
shell-escapes env: values but runs no shell, so DRIGA_DATA_DIR became
"/Users/me/Library/Application\ Support/driga" with a literal backslash.
Every upgrade then installed a service collecting into a stray directory,
and the app and CLI fell back to snapshot mode.
The postflight now runs /usr/bin/env with the assignments as arguments,
which Homebrew passes unchanged. The cask test uses a data directory with a
space, and the release check requires the new form and rejects env:.