Repository navigation
refactor!: name the structured query after queries and use last_evaluated_at - #411
Merged
Merged
Conversation
…ated_at The structured query serves dashboards, FanQL, MCP and the builder, so internal/panel becomes internal/query (panel.Query is now query.Spec, PanelTime is TimeOverride, QueryShape is Shape) and the DuckDB layer it displaced moves to internal/engine. The read routes move from /api/panels/* to /api/queries/run, /api/queries/exemplars and /api/queries/variables/resolve with no aliases; clients, authorization, tests and generated docs change together. Alert rules name their last evaluation instant last_evaluated_at like other event instants; a new migration renames the column. Closes #403.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Closes #403. Breaking API change; no aliases or fallback routes.
internal/query(wasinternal/panel):panel.Query→query.Spec,PanelTime→TimeOverride,QueryShape→Shape. The DuckDB execution layer moves tointernal/engine.POST /api/panels/query→POST /api/queries/run,/api/panels/exemplars→/api/queries/exemplars,/api/panels/variables/resolve→/api/queries/variables/resolve.Authorization classification, the UI client, e2e and eval harnesses,
and generated API docs change together.
last_eval→last_evaluated_at(JSON and column), through the newmigration
20261030000000_alert_last_evaluated_at.sqlwith its checksum../internal/engine.Verification
just check(pre-push)just test-raceon query, engine, api, mcp, fanql, alert, storejust db-genand storage tests; migration ledger extended