docs: correct stable row ID migration and storage - #8852
docs: correct stable row ID migration and storage#8852lance-gatefixer[bot] wants to merge 100 commits into
Conversation
|
Important Format specification voteThis PR modifies the Lance format specification, so it requires 3 binding +1 votes from PMC members (excluding the proposer) and a minimum 72-hour voting period, weekends excluded, before it can merge. Vote by approving this PR (+1) or requesting changes (−1, a veto). See the voting process. Status: ❌ Blocked — 0 of 3 required approvals
Updated automatically by the format-spec vote gate, which re-checks every 15 minutes — just voted? Re-check now (press Run workflow; leave the input blank to re-check every open format PR). A PMC member may apply the |
|
Blocked: the current head cannot pass Remote head |
|
Blocked: the current head cannot pass Remote head |
|
Blocked: the current head is held by an unrelated Windows runner failure and the required format-spec approval gate. Remote head |
|
Blocked: the current head remains held by an unrelated Windows hosted-runner failure and the required format-spec approval gate. Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33217104161 and reports 0/3 PMC approvals on this commit; its evaluator job 99003082863 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33218990261 and reports 0/3 PMC approvals on this commit; its evaluator job 99008845859 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33219934264 and reports 0/3 PMC approvals on this commit; its evaluator job 99011652281 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33220685156 and reports 0/3 PMC approvals on this commit; its evaluator job 99013887195 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: PR #8852 at remote head b0036e2 remains held by an inherited exact-base Rust test failure and the required format-spec approval gate. Remote head b0036e2 contains current main tip 862de0b. Current-head Rust run 34089092525 and exact-base main run 34088003278 both fail windows-build, mac-build (stable), linux-build, and linux-arm in test_partial_compound_hybrid_prunes_same_path_different_base_rewrite with All data files must have the same version. Detected both 2.2 and 2.1; this repair changes only Markdown and protobuf comments. Separately, format-spec evaluator run 34106607458 completed successfully but reports PR #8852: 0/3 PMC approvals on this commit. I fetched both branches, verified base ancestry and Ready PR identity, read the live issue, PR, reviews, inline and PR conversations, checks, and logs, ran git diff --check, and compiled protos/table.proto; no attributable branch defect remains to repair or push. The smallest next actions are to land the upstream fix for the failing exact-base Rust test on main, update this repair branch from that fixed base, and obtain three eligible PMC approvals. As a practical vote alternative, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 at remote head fa391f9 remains held by an unrelated Rust recall failure and the required format-spec approval gate. Remote head fa391f9 contains current main tip 2e889d3. Current-head Rust run 34109965912 job 101703667101 failed only test_legacy_ivf_pq_cosine_multivec_smoke at recall 0.49, while exact-base main run 34108802788 job 101699945040 passed the same test; this branch changes only Markdown and protobuf comments, and the focused current-head CI-feature test passes locally. Separately, format-spec evaluator run 34112064650 job 101710333425 completed successfully but reports PR #8852: 0/3 PMC approvals on this commit. I fetched both branches, verified current-base ancestry and Ready PR identity, inspected the live checks and logs, compared the exact-base result, ran the focused CI-feature test and git diff --check, and found no attributable code defect to repair or push. The smallest next actions are to rerun the failed linux-build job and obtain three eligible PMC approvals. Practical alternatives are to rerun the full Rust workflow and, if this documentation-only correction qualifies as trivial, have a PMC member apply format-waived. |
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The pull-request patch remains unchanged. The new base fix replaces query-time scalar-index cache entries on object-store rotation but leaves stable-row-ID migration, index metadata, CreateIndex commits, transaction conflict resolution, and row/version-sequence storage unchanged. The corrected migration, index-quiescence, and compatibility guidance remains accurate.
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head 0c60be6 cannot satisfy the required format-spec-vote gate until it receives three eligible PMC approvals. Remote head 0c60be6 contains the current main tip bea84cc. The live format-spec-vote status reports 0/3 PMC approvals on this commit and targets Actions run 34129212459; evaluator job 101765017484 completed successfully, and all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and Ready PR identity, inspected the current checks, evaluator logs, reviews, inline comments, and PR conversation, reran protobuf descriptor compilation, the MkDocs build, and git diff checks, and pushed normally with the branch already up to date. No attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 at remote head 0c60be6 cannot satisfy the required format-spec-vote gate until it receives three eligible PMC approvals. Remote head 0c60be6 contains the current main tip bea84cc. The live format-spec-vote status reports 0/3 PMC approvals on this commit and targets Actions run 34130740123; evaluator job 101769976339 completed successfully, and all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and Ready PR identity, inspected the current checks, evaluator logs, reviews, inline comments, and complete PR conversation, reran protobuf descriptor compilation, the MkDocs build, and git diff checks, and pushed normally with the branch already up to date. No attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 at remote head 0c60be6 cannot satisfy the required format-spec-vote gate until it receives three eligible PMC approvals. Remote head 0c60be6 contains the current main tip bea84cc. The live format-spec-vote status reports 0/3 PMC approvals on this commit and targets Actions run 34132807897; evaluator job 101776736842 completed successfully, and all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and Ready PR identity, inspected the current checks, evaluator logs, reviews, inline comments, and complete PR conversation, reran protobuf descriptor compilation, the MkDocs build, and git diff checks, and pushed normally with the branch already up to date. No attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 at remote head 0c60be6 cannot satisfy the required format-spec-vote gate until it receives three eligible PMC approvals. Remote head 0c60be6 contains the current main tip bea84cc. All 33 current-head CheckRuns are successful; the sole failing commit status is format-spec-vote, which targets Actions run 34134748067. Evaluator job 101782934189 completed successfully while reporting PR #8852: 0/3 PMC approvals on this commit. I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 at remote head 0c60be6 cannot satisfy the required format-spec-vote gate until it receives three eligible PMC approvals. Remote head 0c60be6 contains the current main tip bea84cc. All 33 current-head CheckRuns are successful; the sole failing commit status is format-spec-vote, which targets Actions run 34136139729. Evaluator job 101787444347 completed successfully while reporting PR #8852: 0/3 PMC approvals on this commit. I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 at remote head 0c60be6 cannot satisfy the required format-spec-vote gate until it receives three eligible PMC approvals. Remote head 0c60be6 contains the current main tip bea84cc. All 33 current-head CheckRuns are successful; the sole failing commit status is format-spec-vote, which targets Actions run 34138004155. Evaluator job 101793359379 completed successfully while reporting PR #8852: 0/3 PMC approvals on this commit. I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 at remote head Remote head I fetched and verified both assigned refs and the Ready PR identity, inspected the live Issue, reviews, inline and PR conversations, checks, and evaluator log, compiled the protobuf descriptor, built the documentation, checked the diff, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the vote gate. A practical alternative is for a PMC member to apply |
|
Blocked: PR #8852 cannot pass the format-spec-vote policy gate at remote head 0c60be6 because the current status is 0/3 PMC approvals on this commit. Evidence: the format-spec-vote status links Actions run 34153043135, whose evaluator job 101839077580 completed successfully and explicitly reports “PR #8852: 0/3 PMC approvals on this commit.” All other reported checks pass. The current origin/main tip bea84cc is an ancestor of this repair head. Attempted: refreshed the live check and evaluator logs, validated the proto descriptor and MkDocs build, ran git diff --check, and pushed the assigned branch normally; it was already up to date. Next action: obtain three PMC approvals on this exact commit, then rerun the Format spec vote gate. As a practical alternative if approval will not be pursued, a maintainer can revise or withdraw the format proposal through the normal project process. |
Summary
Root cause
The format documentation and protobuf comments still described pre-implementation plans: they said existing datasets could not migrate and presented a 200 KB inline/external threshold as active writer behavior. Migration has since shipped, but writers still emit every sequence inline and readers cannot load external version sequences.
Validation
protoc --proto_path=../protos --descriptor_set_out=/dev/null ../protos/table.protouv run mkdocs build(completed with pre-existing missing-link warnings outside this change)git diff --checkFixes #8851