perf(cleanup): avoid reading manifests for version retention - #9019
Open
ziwenzhang wants to merge 1 commit into
Open
perf(cleanup): avoid reading manifests for version retention#9019ziwenzhang wants to merge 1 commit into
ziwenzhang wants to merge 1 commit into
Conversation
Author
|
cc @zhangyue19921010 would you mind taking a look when you have a chance? Thanks! |
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The retention cutoff depends only on ordered attached version IDs, so reusing the lightweight version-reference listing preserves the existing branch, gap, and detached-manifest semantics while removing per-manifest payload reads. The focused regression covers both the cutoff and that I/O contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
performs zero object-store reads.
Testing