fix(table): surface a malformed manifest size from DynamoDB - #9023
Open
jackylee-ch wants to merge 1 commit into
Open
fix(table): surface a malformed manifest size from DynamoDB#9023jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
A manifest row's size attribute was read with .ok(), so a value that is not a number silently became None. The sibling version field, parsed from the same item seven lines below, reports the same failure with a descriptive error. Losing the size is not free either: read_manifest falls back to a HEAD request for the length, so a corrupt row costs an extra round trip on every read and gives no signal why. Read the attribute in one place, keeping an absent value as None for rows written before the column existed and reporting a present one that is not a parseable number.
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The shared parser preserves the legitimate legacy absence case while consistently rejecting malformed stored metadata in both DynamoDB lookup paths. This enforces the existing (path, size) contract without changing writers or requiring migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A manifest row's
sizeattribute was read with.ok(), so a value that is not a number silently becameNone. The siblingversionfield, parsed from the same item seven lines below, reports the same failure with a descriptive error:Losing the size is not free either —
read_manifestfalls back to aHEADrequest for the length, so a corrupt row costs an extra round trip on every read and gives no signal why.Read the attribute in one place: an absent value stays
Nonefor rows written before the column existed, and a present one that is not a number is reported.