feat(scanner): ignore selected scalar indices - #9034
Draft
majin1102 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with_ignored_scalar_indices), Java (ignoredScalarIndexes), and Python (ignored_scalar_indices)Motivation
External query planners can consume a scalar index during task planning and pass the resulting row selection to Lance workers. For example, lance-spark can query a ZoneMap on the driver, produce fragment-local physical slices, and then avoid querying that same ZoneMap again on executors without disabling useful BTree or other scalar indices.
This fills the gap between the existing all-or-nothing
use_scalar_indexoption and retaining every available scalar index.Semantics
use_scalar_index = falsecontinues to disable all scalar-index planningValidation
cargo fmt --all --checkcargo check -p lance --testscd java && ./mvnw spotless:checkcd java && ./mvnw -Dtest=ScannerTest,AsyncScannerTest test(54 Java tests and 22 JNI tests)cd python && cargo check --releaseThe PR is intentionally opened as a draft so the API shape and naming can be discussed before lance-spark adopts it.