-
Notifications
You must be signed in to change notification settings - Fork 357
fix(prompt): preserve non-string content in message placeholders #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
winklemad
wants to merge
1
commit into
langfuse:main
Choose a base branch
from
winklemad:fix/placeholder-non-string-content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-string placeholder content now survives
compile(), butget_langchain_prompt()then passes every compiled message’s content to the string-only_get_langchain_prompt_string(). When the history contains an assistant tool-call turn withcontent=Noneor multimodal list content, this public path raisesTypeError, so the fix remains incomplete for LangChain callers.Knowledge Base Used:
Prompt To Fix With AI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch —
get_langchain_prompt()hits the same string-only path (_escape_json_for_langchaindoeslen(text)), so guardingcompile()alone wasn't enough. Pushed a fix that applies the same isinstance-str guard there too: multimodal list content passes through (LangChain accepts it), and a tool-call turn'sNoneis normalized to""— LangChain rejects a(role, None)template tuple, and""is its convention for a tool-call message. Added aget_langchain_promptregression test that also asserts the result is consumable byChatPromptTemplate.from_messages(...).