feat(api): update API spec from langfuse/langfuse ce4a1e9 - #1901
langfuse-bot wants to merge 1 commit into
Conversation
|
@claude review |
There was a problem hiding this comment.
Claude Code Review
No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Looks good — this is a mechanical, auto-generated Fern API client sync with no bugs found.
What was reviewed: the new shared CursorMetaResponse pagination base class and its wiring through langfuse/api/utils/pagination lazy-import maps; the refactor of ExperimentsResponseMeta, ObservationsV2Meta, GetScoresV3Meta, and CursorMeta to inherit from it instead of duplicating the cursor field; and the removal of the sdk-log ingestion event type (SdkLogEvent/SdkLogBody), confirmed unused elsewhere in the SDK. All changed files carry the Fern auto-generation header and match the described upstream spec bump.
Extended reasoning...
The diff is entirely within langfuse/api/ (Fern-generated client code): a new CursorMetaResponse pagination type, several resource meta types refactored to inherit from it, deprecation-notice docstrings and a new deprecation field on IngestionResponse, and removal of the sdk-log ingestion event type. No security-sensitive surface (auth, crypto, permissions) is touched, and the sdk-log type removal was verified unused elsewhere in the repo. Given the small, mechanical, spec-driven nature of the change and no CODEOWNERS or outstanding review objections, this is safe to approve.
| @@ -67,7 +64,6 @@ | |||
| "IngestionEvent_ObservationCreate": ".ingestion_event", | |||
There was a problem hiding this comment.
Callers that import SdkLogBody, SdkLogEvent, or IngestionEvent_SdkLog to construct sdk-log batches now get an ImportError because those public exports were removed. This takes effect before the documented November 16, 2026 Cloud cutoff and also affects self-hosted callers. Please retain compatibility for these imports while those callers are supported.
Prompt To Fix With AI
This is a comment left during a code review.
Path: langfuse/api/ingestion/types/__init__.py
Line: 64
Comment:
**Public SDK-log imports break**
Callers that import `SdkLogBody`, `SdkLogEvent`, or `IngestionEvent_SdkLog` to construct `sdk-log` batches now get an `ImportError` because those public exports were removed. This takes effect before the documented November 16, 2026 Cloud cutoff and also affects self-hosted callers. Please retain compatibility for these imports while those callers are supported.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
The PR should not merge until compatibility for the removed public SDK-log imports is addressed.
Summary
This generated API update adds comment and observation timestamp hints, prompt-list filtering, shared cursor metadata, and revised ingestion and real-time API guidance.
Reviews (1) · Last reviewed commit: "feat(api): update API spec from langfuse..."