feat(api): update API spec from langfuse/langfuse 8beb5be - #1904
langfuse-bot wants to merge 1 commit into
Conversation
|
@claude review |
There was a problem hiding this comment.
Claude Code Review
No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.
Tip: disable this comment in your organization's Code Review settings.
| @@ -67,7 +64,6 @@ | |||
| "IngestionEvent_ObservationCreate": ".ingestion_event", | |||
There was a problem hiding this comment.
SDK-log imports removed Existing callers that import
IngestionEvent_SdkLog, SdkLogBody, or SdkLogEvent can no longer start: this change removes their public exports and model definitions. The updated ingestion guidance says non-score events are rejected only from November 16, 2026, so typed callers lose access before that transition. Retain the imports during the transition or provide a compatible migration path.
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: langfuse/api/ingestion/types/__init__.py
Line: 64
Comment:
**SDK-log imports removed** Existing callers that import `IngestionEvent_SdkLog`, `SdkLogBody`, or `SdkLogEvent` can no longer start: this change removes their public exports and model definitions. The updated ingestion guidance says non-score events are rejected only from November 16, 2026, so typed callers lose access before that transition. Retain the imports during the transition or provide a compatible migration path.
**Knowledge Base Used:**
- [API client and service surface](https://app.greptile.com/personal-org-4986/-/custom-context/knowledge-base/langfuse/langfuse-python/-/docs/api-client-and-service-surface.md)
- [Shared models and data serialization](https://app.greptile.com/personal-org-4986/-/custom-context/knowledge-base/langfuse/langfuse-python/-/docs/shared-models-and-data-serialization.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. Because it's a large, mechanically-generated change across 67 files in the Fern API client, a human look would still be worthwhile.
What was reviewed: the new unstable/skills API surface (client, raw_client, ~14 type modules) and its wiring into unstable/init.py and client.py; the pagination "meta" response renames across many resource modules; and the Dataset/CreateDatasetRequest input_schema/expected_output_schema type narrowing from Any to Dict[str, Any] — this matches the upstream JSON-Schema contract (schemas are objects) rather than being an accidental regression.
Extended reasoning...
The diff is confined to the auto-generated langfuse/api/ Fern client: a new "skills" resource (CRUD client/raw_client/types) plus mechanical pagination-meta renames and two field type narrowings (Any -> Dict[str, Any]) on Dataset/CreateDatasetRequest schema fields. No hand-written business logic, auth, or security-sensitive code paths are touched. The dataset type-narrowing was checked against the SDK's create_dataset wrapper and appears to be a faithful reflection of the upstream JSON-Schema-as-object contract rather than a bug. Given the sheer size (67 files, ~3295 insertions) of generated code, a human skim is still reasonable even though no concrete issues were found.
The PR should not merge until the SDK-log import compatibility break and the explicit import-placement requirement are addressed.
Summary
The PR refreshes generated API models and documentation, adds sync and async unstable skills operations, and updates pagination metadata. It also removes public SDK-log ingestion types. The removed imports break existing typed callers; the new skills examples contain an invalid import path, and the skills properties violate the repository’s import-placement requirement.
Reviews (1) · Last reviewed commit: "feat(api): update API spec from langfuse..."