Repository navigation
migrate --incremental: stop patching deprecatedDate in the lifecycle fast path - #36
Merged
Merged
Conversation
…fast path Same root cause as the 3.4.1 flag-level fix: a lone replace /deprecatedDate is rejected by the API, so every incremental run failed each already-deprecated flag (5 in the SoSafe project) and exited 1. Found in the incremental dry run after the first real migration. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow change removes the rejected operation while preserving supported reconciliation, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Fixes incremental migration failures by extending #32’s removal of unsupported deprecatedDate patches to the unchanged-flag fast path.
Changes:
- Removes timestamp reconciliation while preserving lifecycle-state and tag updates.
- Bumps the version to 3.4.2 and documents the fix.
| File | Description |
|---|---|
src/scripts/launchdarkly-migrations/migrate_between_ld_instances.ts |
Removes the unsupported timestamp patch. |
deno.json |
Updates the version to 3.4.2. |
CHANGELOG.md |
Documents the incremental migration fix. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32. The incremental fast path (lifecycle/tags reconciliation for flags whose versions are unchanged) still emitted a stand-alone
replace /deprecatedDate, which the API rejects with "Unsupported json-patch operation". Since 3.4.0 counts a failed lifecycle reconciliation as an error, every--incrementalrun would fail each already-deprecated flag and exit 1.Found by an incremental dry run against the SoSafe projects right after the first real migration: 5 deprecated flags were about to get a 1-operation lifecycle patch although they were already deprecated in the destination.
Fix: drop the
deprecatedDatecomparison from the lifecycle patch, mirroring the flag-level fix in #32.deprecatedandarchivedare still reconciled.Tests: 182 passed;
deno checkclean.🤖 Generated with Claude Code