Repository navigation
fix: a list emptied by a search or a filter says so, and empty lists name the controls on their tab - #2923
Merged
Conversation
…name the controls on their tab - Uninstaller, Right-click Menu, Task Scheduler and Preinstalled Apps show a "no matches" state when a search or a filter hides everything, and keep the "nothing listed" advice for a list with nothing in it. - DNS & Hosts, Startup Manager, System Logs, Right-click Menu and Task Scheduler name their controls as the tab shows them; Startup Manager's switch label and its advice read one string. - ArchitectureTests.EveryEmptyStateMessage_NamesOnlyControlsItsViewHas checks quoted labels and pressed buttons against each view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2811.
Four lists gave the advice for an empty list when a search or a filter had emptied them, and five empty states named controls that are not on their tab.
AllApps.Count,HasEntries,HasTasks,HasApps), and a second state with the search glyph, onHasNoResults, says that nothing matches and how to bring the rest back, worded as Process Manager and Windows Features word theirs. On Right-click Menu it also covers the location box and "Show system entries", and on Task Scheduler "Hide system tasks", which can hide everything with no search typed.HideSystemLabel, so they cannot drift apart again. Its toolbar also said "Click Scan" until the first scan ended, beside a button labelled Refresh. System Logs says switches, not checkboxes. Right-click Menu and Task Scheduler said to run a scan; their button is Refresh.ArchitectureTests.EveryEmptyStateMessage_NamesOnlyControlsItsViewHas. It reads every literal empty-state message in the views, and requires a quoted label to be someContentorTextin the same view, and the words after "press" or "click" to start with one. It found 3 quoted labels and 11 named buttons when measured, and fails below 2 and 9. A message bound to a view-model property is not read, which is why Startup Manager's goes through one string.The new states say to clear the search rather than carry a Clear button:
EmptyStatehas no button, and adding one is a design change of its own.Docs
README: a short "Empty lists" section after "CSV exports".
Tests
HasNoResultsset by a search with no match and cleared with it on all four tabs, on Right-click Menu also by the location and by the system entries hidden by default, and on Task Scheduler by "Hide system tasks"; not set when nothing is listed or the first read failed; Task Scheduler's advice names Refresh; Startup Manager's advice quotesHideSystemLabel, and its toolbar names Refresh until the first scan ends.FilteredOutListViewUiTests(integration, 8 cases) loads the four real views with real view models, over fakes that read nothing on the PC. Each view shows its "no matches" state and not its "nothing listed" one when a search or a filter emptied the list, the reverse when nothing is listed, and Right-click Menu neither with an entry shown.ArchitectureTests,InclusiveTermsTestsand the five view-model test files (392), and the new view tests withStartupViewUiTestsandRecentChangesViewUiTests(19). All four projects build with 0 warnings, anddotnet format --verify-no-changesis clean.