Repository navigation
fix: Edge/OneDrive Remover says why Edge will call itself managed by an organization while it is disabled - #2938
Merged
Conversation
…an organization while it is disabled - EdgeOneDriveService.ManagedBrowserNotice says that while Edge is disabled it shows "Your browser is managed by your organization", that the message comes from the two Edge policies SysManager sets and not from anything harmful, and that Restore Edge removes it. The Disable confirmation ends with it, the Edge card shows it, and the README quotes it. - The Restore confirmation says it ends that message, from ManagedBrowserMessage. - ArchitectureTests.TheManagedBrowserNotice_IsWrittenInOnePlace_AndTheCardAndTheReadmeSayIt holds the app to one copy, the card to its binding and the README to the notice's words.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2880.
Confirmed in the code: "Disable & de-integrate Edge" writes
BackgroundModeEnabled = 0andStartupBoostEnabled = 0underHKLM\SOFTWARE\Policies\Microsoft\Edge, which are machine policies, and Edge says it is managed by an organization while any is set. Neither the confirmation, the card nor the README said so. I did not set the policies on this PC to watch Edge say it; the message is how Edge describes any machine policy.The changes:
EdgeOneDriveService.ManagedBrowserNotice: "While Edge is disabled, it says "Your browser is managed by your organization" in its menu and settings. That message comes from the two Edge policies SysManager sets, not from anything harmful. Restore Edge removes them, and the message with them, unless something else on this PC sets Edge policies too." The last clause is there because Restore deletes only those two values, so a policy set by anything else keeps the message.Subtlestyle and spacing.ManagedBrowserMessage, so the words Edge shows are written once.ArchitectureTests.TheManagedBrowserNotice_IsWrittenInOnePlace_AndTheCardAndTheReadmeSayItfails a second copy of the message in the app's code, a card that no longer bindsEdgeManagedNotice, and a README that says it in other words.Docs
README, Edge/OneDrive Remover: the Edge bullet quotes the notice.
Tests
EdgeOneDriveViewModelTests: the Disable confirmation carries the notice, the Restore confirmation says it ends the message, and the card's property is the notice.EdgeOneDriveViewModelTests,EdgeOneDriveServiceTests,ArchitectureTestsandInclusiveTermsTests(335). All four projects build with 0 warnings, anddotnet format --verify-no-changesis clean. The card's new line has not been looked at on screen yet.