Repository navigation
fix: Escape no longer ends an app update, an install or a component store cleanup part-way - #2949
Merged
Conversation
…tore cleanup part-way - App Updates and Bulk Installer gave the running winget the token Cancel cancels, and Escape runs Cancel, so a keypress ended winget and the installer it had started. The running winget now gets a token of its own, which only Dispose cancels, as Uninstaller's has since 1.130.52. Cancel and Escape stop the batch before its next app, the status line says it waits for the one running, and the batch's summary says where it stopped. - Quick Cleanup's Escape ran Cancel during /StartComponentCleanup, which leaves Windows to finish the servicing transaction on its own. EscapeCancel now returns null while the cleanup runs, and still stops the temporary-file clean-up, the Recycle Bin and the analysis. The Cancel button still stops the cleanup, as its confirmation says. - ARCHITECTURE's count of the tabs that override EscapeCancel is 25, without System Fixes since 1.130.52.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape runs a tab's Cancel command while the tab is busy, and on these three tabs that command's token reached the
process applying the change, so a bare keypress ended it part-way.
What changed
cancels, as Uninstaller's has since 1.130.52. Cancel and Escape stop the batch before its next app. While an app
is updating or installing, the status line says the batch stops after it, and the summary says where it stopped:
"Stopped after 1 of 3. Updated 1." on App Updates, "Installation cancelled after 1/3. Installed: 1, Failed: 0." on
Bulk Installer, which said only "Installation cancelled." before.
EscapeCancelreturns null while/StartComponentCleanupruns, so Escape leaves the cleanupalone, and still stops the temporary-file clean-up, the Recycle Bin and
/AnalyzeComponentStore. The Cancel buttonstill stops the cleanup, as the confirmation before it says. The view's Cancel button is always on screen, so
EveryCancellableTab_LetsEscapeReachItsOwnCancelCommandstill findsIsAnyRunning,CancelCommandand the: nullit asks for.that override
EscapeCancel, which is 25 without System Fixes), CHANGELOG 1.130.56.Tests
status line names the app it waits for, and the second app never starts; closing SysManager still cancels the
running one.
EscapeCancelis null and the Cancel button still cancels DISM's token;during a held analysis Escape cancels it; and after a cleanup has ended, Escape stops the other runs again.
Each test failed against the defect it pins: with winget given the token Cancel cancels, with closing SysManager no
longer cancelling it, with no status line while waiting, with the old summaries, with Escape reaching the cleanup,
with the cleanup never marked, and with the mark left after it.
Closes #2942.