Repository navigation
[CaseStudyBanner] Fix text overlap with ribbon on medium viewports - #8220
Conversation
…ewports Signed-off-by: Piyush Tripathi <piyushtripathi9424@gmail.com>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
| Layer / File(s) | Summary |
|---|---|
Set responsive heading padding src/components/Case-study-banner/index.js |
The heading receives 0 3.5rem 0 1.5rem padding by default and 0 2.5rem 0 1rem at widths up to 800px. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix · Severity of issue fixed: Medium
Suggested reviewers: tejaswiverma121-byte
Merge Risk: 
Minimal · previous review 2e979
-
No merge-blocking issue was established for the responsive banner spacing change.
Pre-merge checks: 
5
-
Full details: Linked Issues check
-
Explanation
Issue
#8168requires theCaseStudyBannerheading to clear the absolute-positioned ribbon before the 600px stacking breakpoint. The reviewed change adds right padding to.desc h2at the default size and at widths up to 800px. The large layout is hidden at widths up to 600px, so the change covers the applicable medium-width layout. No separate automated-test requirement appears in the issue.
Full details: Out of Scope Changes check
-
Explanation
The pull request changes only the
.desc h2padding declarations insrc/components/Case-study-banner/index.js. These declarations directly implement the spacing fix for issue#8168. No unrelated behavior or files are changed.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
ℹ️ Recent review info
-
⚙️ Run configuration
-
- Configuration used: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
bd9272a8-1feb-4ead-b3eb-04fdcea31d32
📒 Files selected for processing: 1
-
src/components/Case-study-banner/index.js
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
ℹ️ Recent review info
-
⚙️ Run configuration
-
- Configuration used: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
bd9272a8-1feb-4ead-b3eb-04fdcea31d32
📒 Files selected for processing: 1
-
src/components/Case-study-banner/index.js
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
-
tejaswiverma121-byte
left a comment
There was a problem hiding this comment.
I’d normally question in CSS fixes are:
Does this break alignment on very wide screens?
Does it create overflow or awkward wrapping on some viewports?
Does the fix only cover the intended range?
Hi @tejaswiverma121-byte, thanks for the review!
|
|
Preview deployment for PR #8220 removed. This PR preview was automatically pruned because we keep only the 3 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
Description
This PR fixes #8168
On medium viewport widths (between ~600px and 1200px), the headline in the
CaseStudyBannercollided with the diagonal "CASE STUDY" ribbon in the top-right corner.This PR adds responsive horizontal padding to
.desc h2, ensuring the text wraps cleanly with ample breathing room away from the ribbon while maintaining optical centering.Notes for Reviewers
Screenshots
Signed commits
Summary by CodeRabbit