You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Kanvas] Fix missing documentation links for Timeline (DVR) and Service Performance cards (#8094) - #8282
This PR fixes#8094 by adding the missing documentation links and documentation icons to the Timeline (DVR) and Service Performance cards on the Kanvas Operate page (/cloud-native-management/kanvas/operate).
Both cards now navigate to their intended documentation pages and match the behavior and visual structure of the surrounding feature cards:
Review was skipped as selected files did not have any reviewable changes.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 6af7b0a8-5f9a-4055-8532-64b83c446d1d
Commits
Reviewing files that changed from the base of the PR and between 124eede and 4a0b5fb.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The Timeline (DVR) and Service Performance cards now link to their operator documentation pages and display DocsIcon links. Other cards retain their existing documentation links and hover behavior.
Timeline (DVR) and Service Performance cards now link to their respective operator documentation pages and display DocsIcon elements. Styling and formatting changes do not alter existing styles or other cards’ hover behavior.
Both cards link to their requested documentation. No merge-blocking risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely identifies the main change: adding missing documentation links for the Timeline (DVR) and Service Performance cards.
Linked Issues check
Issue #8094 requires documentation navigation for both cards. In src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js, the Timeline (DVR) card links to `https://docs.layer5.io/kanvas/…
Out of Scope Changes check
The changes remain within the feature-card implementation in src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js. The broader JSX and styled-component edits reformat the same card mark…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check
Explanation
Issue #8094 requires documentation navigation for both cards. In src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js, the Timeline (DVR) card links to https://docs.layer5.io/kanvas/operator and includes DocsIcon. The Service Performance card links to https://docs.layer5.io/kanvas/operator/performance-testing and includes DocsIcon. Both cards retain the surrounding card structure and hover handlers.
Full details: Out of Scope Changes check
Explanation
The changes remain within the feature-card implementation in src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js. The broader JSX and styled-component edits reformat the same card markup and preserve the existing card URLs, content, and interaction logic. No unrelated product area or behavior is changed.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Nice fix - this does exactly what #8094 asks for. Both cards now behave like their siblings: wrapped in a link, with the docs icon in the corner, and the existing hover/darken handling carried over unchanged, so the two cards no longer sit on the grid looking clickable but going nowhere. I checked the styled-component block against master and the large reformat is whitespace only - the inner/darken/feature-image nesting is unchanged, so there is no styling regression hiding in the 315-line diff.
One note, not a blocker: the whole-file prettier reformat buries the actual two-card change in the diff. If you push another revision, splitting the reformat into its own commit would make the functional change reviewable at a glance. As it stands, no changes needed - the links match the issue exactly, and the build and DCO checks are green.
Add documentation links and docs icon to Timeline (DVR) and Service Performance feature cards on Kanvas Operate page to ensure consistent navigation.
Fixeslayer5io#8094
Signed-off-by: Piyush Tripathi <piyushtripathi9424@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #8094 by adding the missing documentation links and documentation icons to the Timeline (DVR) and Service Performance cards on the Kanvas Operate page (
/cloud-native-management/kanvas/operate).Both cards now navigate to their intended documentation pages and match the behavior and visual structure of the surrounding feature cards:
https://docs.layer5.io/kanvas/operatorhttps://docs.layer5.io/kanvas/operator/performance-testingScreenshots / Screen Recordings
Issue.mp4
Notes for Reviewers
http://localhost:8000/cloud-native-management/kanvas/operate.Signed commits
Summary by CodeRabbit