Skip to content

[Kanvas] Fix missing documentation links for Timeline (DVR) and Service Performance cards (#8094) - #8282

Merged
Katotodan merged 3 commits into
layer5io:masterfrom
piyushtripathi9424:fix-kanvas-operate-cards-8094
Nov 6, 2026
Merged

Katotodan merged 3 commits into
layer5io:masterfrom
piyushtripathi9424:fix-kanvas-operate-cards-8094

Conversation

@piyushtripathi9424

@piyushtripathi9424 piyushtripathi9424 commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR fixes #8094 by adding the missing documentation links and documentation icons to the Timeline (DVR) and Service Performance cards on the Kanvas Operate page (/cloud-native-management/kanvas/operate).

Both cards now navigate to their intended documentation pages and match the behavior and visual structure of the surrounding feature cards:

  • Timeline (DVR) -> https://docs.layer5.io/kanvas/operator
  • Service Performance -> https://docs.layer5.io/kanvas/operator/performance-testing

Screenshots / Screen Recordings

Issue.mp4

Notes for Reviewers

  • Verified navigation and hover interactions locally on http://localhost:8000/cloud-native-management/kanvas/operate.
  • Verified in both Dark Mode and Light Mode.
  • All pre-commit linters and tests passed.

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • New Features
    • Added documentation links to the Timeline (DVR) and Service Performance feature cards.
  • Style
    • Reformatted the feature-card layout.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6af7b0a8-5f9a-4055-8532-64b83c446d1d
Commits

Reviewing files that changed from the base of the PR and between 124eede and 4a0b5fb.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The Timeline (DVR) and Service Performance cards now link to their operator documentation pages and display DocsIcon links. Other cards retain their existing documentation links and hover behavior.

Changes: Kanvas documentation links

Layer / File(s) Summary
Feature-card documentation links
src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js
Timeline (DVR) and Service Performance cards now link to their respective operator documentation pages and display DocsIcon elements. Styling and formatting changes do not alter existing styles or other cards’ hover behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested labels: project/kanvas

Suggested reviewers: mahakgupta108

Merge Risk: Minimal · previous review ccd4c

Both cards link to their requested documentation. No merge-blocking risk was identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the main change: adding missing documentation links for the Timeline (DVR) and Service Performance cards.
Linked Issues check Passed Issue #8094 requires documentation navigation for both cards. In src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js, the Timeline (DVR) card links to `https://docs.layer5.io/kanvas/…
Out of Scope Changes check Passed The changes remain within the feature-card implementation in src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js. The broader JSX and styled-component edits reformat the same card mark…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check

Explanation

Issue #8094 requires documentation navigation for both cards. In src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js, the Timeline (DVR) card links to https://docs.layer5.io/kanvas/operator and includes DocsIcon. The Service Performance card links to https://docs.layer5.io/kanvas/operator/performance-testing and includes DocsIcon. Both cards retain the surrounding card structure and hover handlers.

Full details: Out of Scope Changes check

Explanation

The changes remain within the feature-card implementation in src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js. The broader JSX and styled-component edits reformat the same card markup and preserve the existing card URLs, content, and interaction logic. No unrelated product area or behavior is changed.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2aa20698-46f9-4b04-9892-10ce2e852579
Commits

Reviewing files that changed from the base of the PR and between 0333e0c and ccd4c88.

Files selected for processing: 1

  • src/sections/Kanvas/Kanvas-visualize/kanvas-visualize-features.js

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Preview removed because the pull request was closed.

@rahmanaisha rahmanaisha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix - this does exactly what #8094 asks for. Both cards now behave like their siblings: wrapped in a link, with the docs icon in the corner, and the existing hover/darken handling carried over unchanged, so the two cards no longer sit on the grid looking clickable but going nowhere. I checked the styled-component block against master and the large reformat is whitespace only - the inner/darken/feature-image nesting is unchanged, so there is no styling regression hiding in the 315-line diff.

One note, not a blocker: the whole-file prettier reformat buries the actual two-card change in the diff. If you push another revision, splitting the reformat into its own commit would make the functional change reviewable at a glance. As it stands, no changes needed - the links match the issue exactly, and the build and DCO checks are green.

<img src={TimelineDVRClock} alt="Timeline" style={{ position: "absolute", width: "80%" }} />
<img src={TimelineDVR} alt="" className={hoveredFeature == "Feature4" ? "secondary-image-visible" : "secondary-image"} style={{ width: "80%" }} />
<a
href="https://docs.layer5.io/kanvas/operator"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the link #8094 asks for - Timeline (DVR) to the operator page, with the docs icon matching the sibling cards.

@piyushtripathi9424 piyushtripathi9424 Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great feedback and thorough review @rahmanaisha!

I've separated the changes into two distinct commits as suggested:

  1. One commit for the Prettier styling/formatting.
  2. One dedicated commit containing only the functional link additions and <DocsIcon /> components for the two cards.

This makes the functional changes reviewable at a glance.

Piyush Tripathi added 2 commits October 31, 2026 23:43
Signed-off-by: Piyush Tripathi <piyushtripathi9424@gmail.com>
Add documentation links and docs icon to Timeline (DVR) and Service Performance feature cards on Kanvas Operate page to ensure consistent navigation.

Fixes layer5io#8094

Signed-off-by: Piyush Tripathi <piyushtripathi9424@gmail.com>

@Katotodan Katotodan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Katotodan
Katotodan merged commit bc2a733 into layer5io:master Nov 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix missing documentation links for Timeline (DVR) and Service Performance cards

3 participants