Skip to content

[Navigation] Replace invalid 'href' prop with 'to' in Gatsby Link components - #8350

Merged
marblom007 merged 1 commit into
layer5io:masterfrom
ayushbuilds-code:fix/8349-gatsby-link-to-prop
Nov 9, 2026
Merged

marblom007 merged 1 commit into
layer5io:masterfrom
ayushbuilds-code:fix/8349-gatsby-link-to-prop

Conversation

@ayushbuilds-code

@ayushbuilds-code ayushbuilds-code commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR fixes #8349

In multiple diagram and feature sections, Gatsby's <Link> component was used with href="..." instead of the required to="..." prop. In Gatsby, <Link> expects to, and passing href leaves to undefined, triggering React prop type warnings and disabling Gatsby client-side route prefetching and SPA navigation.

This PR updates all 13 occurrences across 6 feature sections to use to="..." instead of href="...".
Additionally, in src/components/Features/TwoColLayout.js, the image card link is updated to point directly to the canonical route /solutions/orchestration-management (matching the adjacent "Learn more" link).

Notes for Reviewers

  • Changes only the prop name from href to to on Gatsby <Link> elements.
  • Fixes the link target in TwoColLayout.js to /solutions/orchestration-management.

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Bug Fixes
    • Updated solution and “Learn more” links across cloud, Kubernetes, and infrastructure pages to navigate correctly within the site.
    • Corrected the orchestration management link to point to its updated destination.

…k components

Signed-off-by: Ayush <ayushdungarwal3445@gmail.com>
@leecalcote
leecalcote requested a review from marblom007 November 9, 2026 07:34
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Several internal Gatsby links now use the to prop instead of href. The orchestration image link now points to /solutions/orchestration-management.

Changes: Internal navigation links

Layer / File(s) Summary
Correct internal Gatsby links
src/sections/AWS-Diagram/diagram.js, src/sections/CloudNativeDeployments/features.js, src/sections/Developer-Infrastructure/features.js, src/sections/GCP-Diagram/diagram.js, src/sections/Kubernetes-Diagram/diagram.js, src/sections/kubernetes-multi-cluster/features.js, src/components/Features/TwoColLayout.js
The internal links use Gatsby’s to prop. The orchestration image link uses the canonical /solutions/orchestration-management destination.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: mahakgupta108, hiyach28

Merge Risk: Minimal · up to 3dfd5

The navigation corrections present no identified merge-blocking risk and are ready to merge after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: Gatsby Link components switch from the invalid 'href' prop to the 'to' prop. The raw summary shows every hunk makes this swap across the feature sections, and the obje…
Linked Issues check Passed [#8349] Requires internal Gatsby <Link> elements to use to instead of href, and requires the TwoColLayout.js image link to target /solutions/orchestration-management. Verified in the whole-PR …
Out of Scope Changes check Passed All changed hunks map to the objectives of #8349. Changes are limited to the href to to prop rename on Gatsby <Link> elements in the six listed sections and the single link-target fix in `TwoCol…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Title check

Explanation

The title names the main change: Gatsby Link components switch from the invalid 'href' prop to the 'to' prop. The raw summary shows every hunk makes this swap across the feature sections, and the objectives confirm it. The title omits the TwoColLayout.js link path update, which is a minor secondary change and is acceptable under the partial-coverage rule.

Full details: Linked Issues check

Explanation

[#8349] Requires internal Gatsby &lt;Link&gt; elements to use to instead of href, and requires the TwoColLayout.js image link to target /solutions/orchestration-management. Verified in the whole-PR diff (merge base dbbe9f5 to head 3dfd5fa): src/components/Features/TwoColLayout.js changes &lt;Link to="/orchestration-management"&gt; to &lt;Link to="/solutions/orchestration-management"&gt;. Verified src/sections/CloudNativeDeployments/features.js (3 links) and src/sections/kubernetes-multi-cluster/features.js (2 links) convert href to to with destinations unchanged. The raw summary reports the same href to to conversion, with unchanged destinations, in the AWS, GCP, Kubernetes diagram, and Developer-Infrastructure files. Total is 13 occurrences, matching the PR description and the issue's file list. Coding requirements are met for the reviewed files. The diagram and Developer-Infrastructure hunks were assessed from the summary only, not from a direct diff read. No automated tests are part of the issue requirements, so none were required. Residual uncertainty: no repository-wide search for other href usages on Gatsby &lt;Link&gt; was run, and the issue does not require one.

Full details: Out of Scope Changes check

Explanation

All changed hunks map to the objectives of #8349. Changes are limited to the href to to prop rename on Gatsby &lt;Link&gt; elements in the six listed sections and the single link-target fix in TwoColLayout.js. The summary reports +1/-1, +2/-2, +3/-3, +2/-2, +2/-2, +2/-2 line changes per file, with no alterations to exported declarations. No unrelated files or logic changes were identified. The diagram and Developer-Infrastructure hunks were checked against the summary only.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 7 files.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/components/Features/TwoColLayout.js

Parsing error: The keyword 'import' is reserved

src/sections/AWS-Diagram/diagram.js

Parsing error: The keyword 'import' is reserved

src/sections/CloudNativeDeployments/features.js

Parsing error: The keyword 'import' is reserved

  • 4 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1eda6184-6b87-4ffd-85ce-13ea633adc8b
Commits

Reviewing files that changed from the base of the PR and between dbbe9f5 and 3dfd5fa.

Files selected for processing: 7

  • src/components/Features/TwoColLayout.js
  • src/sections/AWS-Diagram/diagram.js
  • src/sections/CloudNativeDeployments/features.js
  • src/sections/Developer-Infrastructure/features.js
  • src/sections/GCP-Diagram/diagram.js
  • src/sections/Kubernetes-Diagram/diagram.js
  • src/sections/kubernetes-multi-cluster/features.js

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@marblom007 marblom007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Checked against #8349: all 13 href props on Gatsby Link components are now to, each touched file imports Link from gatsby, and the TwoColLayout image link now points to /solutions/orchestration-management, matching the adjacent Learn more link. Build, DCO, triage, and CodeRabbit checks are green. Thanks for the fix.

@marblom007
marblom007 merged commit 23a68e2 into layer5io:master Nov 9, 2026
5 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for PR #8350 removed.

This PR preview was automatically pruned because we keep only the 3 most recently updated previews on GitHub Pages to stay within deployment size limits.

If needed, push a new commit to this PR to generate a fresh preview.

@ayushbuilds-code
ayushbuilds-code deleted the fix/8349-gatsby-link-to-prop branch November 9, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix invalid 'href' prop in Gatsby Link components and canonical feature route

2 participants