chore: remove FinFun, a duplicate of Mathlib's Finsupp - #814
Open
SamuelSchlesinger wants to merge 1 commit into
Open
chore: remove FinFun, a duplicate of Mathlib's Finsupp#814SamuelSchlesinger wants to merge 1 commit into
SamuelSchlesinger wants to merge 1 commit into
Conversation
SamuelSchlesinger
requested review from
chenson2018 and
fmontesi
as code owners
August 17, 2026 23:24
FinFun mirrors Finsupp field for field, including the update lemma cluster (update_apply/self/comm/idem) and the ->0 notation, and has no consumers anywhere in the library. Remove it together with DecidableEqZero, whose only user it was, and the corresponding grind-lint exceptions.
Collaborator
|
cc @fmontesi. I'd planned to remove this after the |
SamuelSchlesinger
force-pushed
the
samschlesinger/remove-finfun
branch
from
August 17, 2026 23:33
6d01cbb to
044d6c5
Compare
Collaborator
|
Yes, we use it heavily, so I'd like to keep this for now, but I'd prefer a computable version of Finsupp, too. Using the same notation was done with the intention of facilitating a future transition. Can you point me to the mathlib work? There's a lot of stuff in Finsupp that I'd like to use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FinFun mirrors Finsupp field for field, including the update lemma cluster (update_apply/self/comm/idem) and the ->0 notation, and has no consumers anywhere in the library. Remove it together with DecidableEqZero, whose only user it was, and the corresponding grind-lint exceptions.
I believe at some point there was a justification to duplicate based on computability, but given there are no consumers lets just drop it now.