setup: type-check test/ during npm run build

CONTRIBUTING.md

@@ -48,11 +48,8 @@ network — nothing in the suite makes an RPC call. Code that talks to a server
 structural fake, as in `test/futility.test.ts`, which stands up an object shaped like `rpc.Server`
 and asserts on which calls it received.
 
-Two things worth knowing before you add a test:
+One thing worth knowing before you add a test:
 
-- **`test/` is not type-checked.** `tsconfig.json` excludes it, so `npm run build` will not catch a
-  type error in a test file. This is a known gap with an open issue against it; until it closes, do
-  not assume a green build means your test compiles under `strict`.
 - **Relative imports need the `.js` extension**, including in tests. The package is
   `"type": "module"` with `moduleResolution: "NodeNext"`, so `../src/keeper/loop.js` is correct even
   though the file on disk is `loop.ts`.

package.json

@@ -15,7 +15,7 @@
     "dist"
   ],
   "scripts": {
-    "build": "tsc -p tsconfig.json",
+    "build": "tsc -p tsconfig.json && tsc -p tsconfig.test.json",
     "lint": "eslint .",
     "format": "prettier --write .",
     "format:check": "prettier --check .",

test/discover.test.ts

@@ -86,7 +86,12 @@ describe("unwrapPage", () => {
   });
 
   it("throws on an Err, naming the start offset", () => {
-    expect(() => unwrapPage(new contractSpec.Err("LimitTooLarge"), 50)).toThrow(/start=50/);
+    // The SDK types `Err` as wrapping an `ErrorMessage` ({ message }), not a
+    // bare string; `unwrapPage` only stringifies it, so the payload is not
+    // asserted on here.
+    expect(() => unwrapPage(new contractSpec.Err({ message: "LimitTooLarge" }), 50)).toThrow(
+      /start=50/,
+    );
   });
 
   it("throws when the payload is not a list", () => {

test/ttl.test.ts

@@ -51,7 +51,10 @@ describe("classify", () => {
 
 describe("buildReadings", () => {
   it("pairs each requested key with its entry", () => {
-    const keys = [instanceLedgerKey(CONTRACT), symbolKey("Balance")];
+    const keys: [xdr.LedgerKey, xdr.LedgerKey] = [
+      instanceLedgerKey(CONTRACT),
+      symbolKey("Balance"),
+    ];
     const entries = [
       { key: keys[0], val: {}, liveUntilLedgerSeq: 600_000 },
       { key: keys[1], val: {}, liveUntilLedgerSeq: 150_000 },
@@ -68,7 +71,10 @@ describe("buildReadings", () => {
   });
 
   it("marks a key the RPC omitted as archived", () => {
-    const keys = [instanceLedgerKey(CONTRACT), symbolKey("Milestones")];
+    const keys: [xdr.LedgerKey, xdr.LedgerKey] = [
+      instanceLedgerKey(CONTRACT),
+      symbolKey("Milestones"),
+    ];
     const entries = [{ key: keys[0], val: {}, liveUntilLedgerSeq: 600_000 }];
     const readings = buildReadings(keys, entries, 100_000, 100_000);
 

tsconfig.json

@@ -18,5 +18,5 @@
     "forceConsistentCasingInFileNames": true
   },
   "include": ["src/**/*.ts"],
-  "exclude": ["node_modules", "dist", "test"]
+  "exclude": ["node_modules", "dist"]
 }

tsconfig.test.json

@@ -0,0 +1,9 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noEmit": true,
+    "rootDir": "."
+  },
+  "include": ["test/**/*.ts", "src/**/*.ts"],
+  "exclude": ["node_modules", "dist"]
+}