[levz0r]

Fixes the two failures behind the recent Chrome Web Store reviews ("nothing actually happens"; "it sends me to another page").

What was wrong

1. "Saved!" on every outcome. popup.js awaited sendMessage but never looked at response.success, so protected pages and failed captures still showed "Saved!" with no file.
2. Capture clicked menu links. expandCollapsedSections() calls .click() on every [aria-expanded="false"], .expand, .collapsed, … element. On a menu link like <a href="/services/" aria-expanded="false">, that navigates the tab away. The injected script dies, executeScript returns no result, and background.js treated that as "user pressed Abort" and returned quietly. The result was a different page, no file, and "Saved!".

Changes

• Popup checks the response and shows a localized reason under the button (en/fr/he/hi): protected page, page navigated, or the raw error text.
• Background
  • Abort now returns { cancelled: true } explicitly.
  • A missing result throws a page-navigated error instead of passing as a cancel.
  • The popup gets a response even when no active tab is found.
• New src/expand-policy.js, injected next to turndown.js. Expansion never clicks:
  • links to a different URL (same-page # and javascript: toggles are still allowed),
  • links with target/download,
  • submit buttons inside a form.
  • <details> elements are still opened.
• Context menu: a failed save sets a red ! badge and stores the error. The popup shows it when opened, then clears it.
• Version 1.2.2 and a CHANGELOG entry.

Verification

• pnpm run format, lint, test: 115 tests pass, including 13 new tests for expand-policy.

• End-to-end in headless Chromium with the built extension, old build (v1.2.1) vs this branch. The test copy adds host_permissions: <all_urls> to stand in for the activeTab grant.

  Scenario	v1.2.1	this PR
  Popup on chrome://version	"Saved!", 0 downloads	"Error – Try again" + protected-page message
  Page with <a href="/services/" aria-expanded="false"> menu	tab navigates to /services/, 0 downloads	no navigation, page saved
  Page whose toggle button navigates via onclick	"Saved!", 0 downloads	page-navigated message
  Context-menu save on a protected page	silent	! badge; popup shows the reason and clears the badge
  Abort pressed during capture	no download	no download, no error shown
  8 real sites (example, apple, microsoft, bbc, shopify, squarespace, wordpress.org, python.org)	all saved	all saved; sizes match or are within normal run-to-run variation

• Firefox was not tested end to end. It uses the same browser.action / storage.local / scripting APIs.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (45ab2d7) to head (15f0d7e).

Additional details and impacted files

@@            Coverage Diff            @@
##           develop       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            4         4           
  Branches         1         1           
=========================================
  Hits             4         4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.