Simplify Homebrew given Intel Mac support dropped - #510
Merged
Merged
Conversation
Always add Homebrew to PATH: The condition is no longer relevant. The only time we didn't have to add it was when Homebrew installed to /usr/local, i.e. on Intel Macs. Remove the failure catch about /usr/local: Same reason: this only happens om Intel Macs. Note: Copilot translated to Chinese for me. I reverse translated through Google Translate to check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always add Homebrew to PATH:
The condition is no longer relevant. The only time we didn't have to add it was when Homebrew installed to /usr/local, i.e. on Intel Macs.
Remove the failure catch about /usr/local:
Same reason: this only happens on Intel Macs.
Auto confirm
brew install. Otherwise it waits foryfrom the user every time.Also aligned the explanations with what we're actually doing.
One change to the homebrew partial, replicated in the other languages.
Note: Copilot translated to Chinese for me. I reverse translated through Google Translate to check.