Repository navigation
Give every page its own meta description - #65
Merged
Merged
Conversation
Pattern pages use the same opening-paragraph summary the catalog shows; extractSummary moves to lib/markdown so both share it. Other pages use their intro text, stored once and rendered by the page too. Amp-Thread-ID: https://ampcode.com/threads/T-01a18b16-89b6-7301-9d0c-e6ff7f681d32 Co-authored-by: Lada Kesseler <archie.kesseler@gmail.com>
extractSummary skipped headings, lists and quotes but not a leading "Related:" or "Closely related:" line, so Feedback Loop was described by its related-reading link instead of its opening paragraph. Amp-Thread-ID: https://ampcode.com/threads/T-01a18b16-89b6-7301-9d0c-e6ff7f681d32 Co-authored-by: Lada Kesseler <archie.kesseler@gmail.com>
lexler
force-pushed
the
feat/page-descriptions
branch
from
October 30, 2026 14:35
3690aaa to
cd8e7e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every page used to share the site-wide description. Each page now has its own.
Stacked on #63 (base:
fix/36-unique-page-titles). The title/description conflicts are resolved in this branch: each page's metadata returns bothtitleanddescription. Merge #63 first; GitHub will then retarget this PR tomain.How
extractSummary(pattern.content), the same opening-paragraph summary the Complete Catalog shows.extractSummarymoves fromapp/pattern-catalog/page.tsxtolib/markdown.tsso both use it.extractSummarynow skips a leadingRelated:/Closely related:line, so it uses the first real paragraph. Feedback Loop was described as "Closely related: "Engineer the Harness""; it's now "Set up automated feedback, give AI permission to iterate autonomously until a goal is reached." The catalog card summary changes the same way.listDescriptionfromgetCategoryConfig, which is the intro the page shows.Tests
pages.test.tsxand 2extractSummarytests inmarkdown.test.ts, each written first and seen failing. Intro-text tests compare the metadata to the rendered paragraph, so the two can't drift apart../test.sh: 387 passed.npm run lint: 0 errors, 0 warnings../e2e.sh: 85 passed, 8 failed, 9 skipped. All 8 failures are iPhone/WebKit search tests from the pre-hydration bug fixed in Keep search text typed before the page finishes loading #64, which this branch doesn't include. Desktop and Android pass.