Skip to content

Use GPT-6.1 Sol for managed subagents - #193

Merged
leynos merged 2 commits into
mainfrom
update-gpt-6-1-sol-models
Oct 1, 2026
Merged

leynos merged 2 commits into
mainfrom
update-gpt-6-1-sol-models

Conversation

@leynos

@leynos leynos commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

Update the managed Codex models for Journeyman, Alchemist, and Natural Philosopher from gpt-6-sol to gpt-6.1-sol, while retaining their reasoning settings. Update the provider contract tests and document the model settings in the users' guide.

No issue, roadmap task, or execplan is associated with this branch.

Review walkthrough

Validation

All repository gates passed sequentially on the final file contents:

make check-fmt     # passed (no formatter configured)
make markdownlint  # passed: 165 files, 0 errors
make lint          # passed
make typecheck     # passed
make test          # passed: 817 tests, 3 snapshots
make spelling      # passed
git diff --check origin/main...HEAD  # clean

Current-head hosted checks: Makefile gates passed; Gecko Security Review passed. Kody, Sourcery, and automerge were skipped. CodeRabbit reports its review as paused.

Notes

The three agents retain their existing reasoning-effort settings. Host-rendered agent files need re-rendering after merge to pick up the new model.

References

Update Journeyman, Alchemist, and Natural Philosopher to the current
GPT-6.1 Sol model and keep their provider contracts pinned in tests.
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 4b913611-92cb-4e85-81b4-1b63b9cf3222

📥 Commits

Reviewing files that changed from the base of the PR and between 1c845f7 and 01463c0.

📒 Files selected for processing (3)
  • agents/subagents.yml
  • tests/test_natural_philosopher.py
  • tests/test_subagent_definitions.py
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


Update the Codex model for Journeyman, Alchemist and Natural Philosopher to gpt-6.1-sol. Keep their existing reasoning-effort settings. Update the provider contract tests to enforce the new model selections.

Run the repository checks reported by the author: formatting, Markdown lint, lint, typecheck, tests, spelling and diff checks all passed. Re-render the host-managed agent files after merge to apply the model changes.

Walkthrough

Set the Codex model to gpt-6.1-sol for Journeyman, Alchemist and Natural Philosopher. Update the related test expectations.

Changes

Codex model update

Layer / File(s) Summary
Model selection and test expectations
agents/subagents.yml, tests/test_natural_philosopher.py, tests/test_subagent_definitions.py
Set the Codex model for Journeyman, Alchemist and Natural Philosopher to gpt-6.1-sol. Update the matching test expectations. Leave the Artisan expectation unchanged.

Priority: ⬇️ Low

Change: Feature

Merge Risk: ⚪ Minimal · up to 01463

The three agents use a documented Codex model, and their tests match the configuration. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
User-Facing Documentation ⚠️ Warning The pull request changes user-facing managed-subagent behaviour. The Codex models for journeyman, alchemist, and natural-philosopher change from gpt-6-sol to gpt-6.1-sol in `agents/subagents… Update docs/users-guide.md in the Sub-agent definitions section. Document that journeyman, alchemist, and natural-philosopher use Codex model gpt-6.1-sol, and state any relevant retained reasoning settings. Keep the documentation …
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Testing (Overall) ✅ Passed Accept the testing coverage. The changed tests load the real agents/subagents.yml through load_provider, then assert the exact gpt-6.1-sol value for Journeyman, Alchemist, and Natural Philosophe…
Developer Documentation ✅ Passed Accept the documentation check. The pull request changes only three managed Codex model values and three matching contract-test expectations. It introduces no internal API, architectural boundary, abs…
Module-Level Documentation ✅ Passed Keep the module documentation unchanged. Both modified Python modules already contain clear module-level docstrings in the base and head revisions. The YAML manifest is configuration, not a Python mod…
Testing (Unit And Behavioural) ✅ Passed Pass the testing check. The change updates three manifest Codex model values and updates the matching contract assertions for Journeyman, Alchemist, and Natural Philosopher. These tests load the real …
Testing (Property / Proof) ✅ Passed Pass. The pull request changes three fixed YAML model values and updates their direct contract assertions. The affected agents form a small, complete table, and the existing parameterized test communi…
Testing (Compile-Time / Ui) ✅ Passed Pass this check. The pull request changes only YAML and Python files, so the Rust/TypeScript compile-time requirement does not apply. The focused contract tests assert the exact gpt-6.1-sol model fo…
Unit Architecture ✅ Passed PASS — The PR changes only three provider model values in agents/subagents.yml and updates the matching contract-test expectations. It adds no query, command, fallible operation, dependency, state m…
Domain Architecture ✅ Passed Pass the domain architecture check. The pull request changes only three Codex model values in the provider manifest and updates their contract tests. It adds no domain logic, persistence, transport, a…
Observability ✅ Passed Pass the observability check. The pull request changes only the Codex model value for three managed agents and updates the matching contract tests. It introduces no new service, process, storage, queu…
Title check ✅ Passed The title clearly describes the main change: updating managed subagents to use GPT-6.1 Sol. No issue, roadmap item, or execplan requires an additional title reference.
Description check ✅ Passed The description directly explains the model updates, affected agents, preserved reasoning settings, tests, validation, and post-merge rendering requirement.
Full details: User-Facing Documentation

Explanation

The pull request changes user-facing managed-subagent behaviour. The Codex models for journeyman, alchemist, and natural-philosopher change from gpt-6-sol to gpt-6.1-sol in agents/subagents.yml. The authoritative diff changes only that manifest and matching tests; it does not change docs/users-guide.md. The user guide describes the managed subagents and provider blocks, but it does not document these Codex model selections or the model change.

Resolution

Update docs/users-guide.md in the Sub-agent definitions section. Document that journeyman, alchemist, and natural-philosopher use Codex model gpt-6.1-sol, and state any relevant retained reasoning settings. Keep the documentation aligned with the manifest and re-render any host agent files after the change.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Three agents take a model name anew
Their test assertions follow suit
Journeyman, Alchemist, Philosopher align
The Artisan keeps its prior line
A small update, recorded true

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the three managed Codex agents using gpt-6-sol to gpt-6.1-sol in the manifest and synchronizes their provider contract tests, without changing reasoning-effort settings or other provider configuration. All listed repository validation gates pass; host-rendered agent files will need re-rendering after merge.

Flow diagram for managed subagent model updates

flowchart LR
    Manifest["Managed subagents manifest"] --> Journeyman["Journeyman\ngpt-6.1-sol\nmedium reasoning"]
    Manifest --> Alchemist["Alchemist\ngpt-6.1-sol\nmedium reasoning"]
    Manifest --> Philosopher["Natural Philosopher\ngpt-6.1-sol\nhigh reasoning"]
    Journeyman --> ContractTests["Provider contract tests"]
    Alchemist --> ContractTests
    Philosopher --> ContractTests
    ContractTests --> Validation["Repository validation gates"]
Loading

File-Level Changes

Change Details Files
Upgrade the Codex model for the three managed Sol-based agents while preserving their existing reasoning effort and other provider settings.
  • Changed Journeyman and Alchemist from gpt-6-sol to gpt-6.1-sol with medium reasoning effort unchanged.
  • Changed Natural Philosopher to gpt-6.1-sol with high reasoning effort unchanged.
agents/subagents.yml
Updated provider contract tests to enforce the new model selection and retain the existing configuration guarantees.
  • Updated Journeyman, Alchemist, and Natural Philosopher expected models to gpt-6.1-sol.
  • Kept assertions for the agents' medium/high reasoning-effort settings.
tests/test_subagent_definitions.py
tests/test_natural_philosopher.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@leynos
leynos marked this pull request as ready for review October 1, 2026 22:43

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @leynos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 3 days and 18 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T22:45:02.343522Z 01463c0 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-01T22:45:57.922625Z 01463c0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

State the GPT-6.1 Sol model and retained reasoning settings for the
three managed sub-agents in the users' guide.
@pandalump

Copy link
Copy Markdown
Collaborator

@coderabbitai The User-Facing Documentation warning in your pre-merge report (#5941852001) was valid for the reviewed head 01463c0; at that point the user guide did not document the managed Codex model selections.

The current PR head is 5987e177af08ed418bde356e59a99a71a91b2014. The Sub-agent definitions section of docs/users-guide.md now states that journeyman and alchemist use gpt-6.1-sol with medium reasoning and natural-philosopher uses the same model with high reasoning (lines 913–914). The provider manifest has those same settings, and the sequential repository gates passed on these final file contents; the current-head Makefile gates and Gecko Security Review are green.

Please confirm that this existing documentation warning is resolved and that there are no remaining actionable CodeRabbit concerns. This is a focused disposition request only; it does not request another review.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail
git rev-parse HEAD
fd --type f '^(users-guide\.md|subagents\.yml)$'
sed -n '898,922p' docs/users-guide.md
rg -n -C5 'gpt-6\.1-sol|reasoning_effort|model_reasoning_effort' agents/subagents.yml
gh api repos/leynos/agent-helper-scripts/issues/comments/5941852001 --jq '{user:.user.login,body}'
gh api --paginate repos/leynos/agent-helper-scripts/issues/193/comments --jq '.[] | select(.user.login == "coderabbitai[bot]" or .user.login == "coderabbitai") | {id,body}'
gh api graphql -f query='query {
  repository(owner:"leynos",name:"agent-helper-scripts") {
    pullRequest(number:193) {
      headRefOid
      reviewThreads(first:100) {
        pageInfo { hasNextPage endCursor }
        nodes {
          isResolved
          comments(first:100) {
            nodes { author { login } body url }
            pageInfo { hasNextPage endCursor }
          }
        }
      }
    }
  }
}'
gh pr checks 193 --repo leynos/agent-helper-scripts

Length of output: 32568


@pandalump The User-Facing Documentation warning is resolved at head 5987e177af08ed418bde356e59a99a71a91b2014.

I verified that docs/users-guide.md matches agents/subagents.yml:

  • journeyman and alchemist: gpt-6.1-sol, medium reasoning.
  • natural-philosopher: gpt-6.1-sol, high reasoning.

No existing actionable CodeRabbit concerns remain. The prior report contains no other warnings or actionable comments, and the PR has no review threads. Makefile gates and Gecko Security Review pass.

This confirms the disposition of the existing warning only. I did not trigger another review. The warning displayed in the earlier report refers to reviewed head 01463c0, not the current head.

You are interacting with an AI system.

@pandalump

Copy link
Copy Markdown
Collaborator

@coderabbitai approve

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
✅ Action performed

Comments resolved and changes approved.

@leynos
leynos merged commit 160a9ac into main Oct 1, 2026
6 checks passed
@leynos
leynos deleted the update-gpt-6-1-sol-models branch October 1, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants