-
Notifications
You must be signed in to change notification settings - Fork 0
Make the build standard the default #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
131dc35
Make Cranelift, mold and the parallel frontend the defaults
leynos 4a7682f
Install the build standard on every lane that compiles
leynos 4555956
Document the build standard and its two exclusions
leynos 2d3ceae
Make the benchmark own its build directories
leynos d409305
Remove the opt-in build path and contract what replaced it
leynos ee7be16
Drop Cranelift from the build standard
leynos c5c1794
Make the benchmark measure compilation, not cache retrieval
leynos aabaea5
Assert the installer's command and fix a stale contract pointer
leynos 61d9d4d
Replace the benchmark table with the conditions a run needs
leynos 99a7b5a
Iterate the benchmark variants without slicing
leynos 56b2aa2
Gate the rustflags contract's Unix-only items
leynos 05fdffd
Narrow the recorded reason for excluding Cranelift
leynos 35cb37c
Reconcile the replayed contracts with main's merges
738c24e
Clear the lint failures and split the modules they exposed
c43d924
Answer the review findings on the build standard
2f89375
Answer the second review pass on the build standard
bef39dc
Answer the third review pass on the build standard
114a84d
Strip the trailing blank line the rebase surfaced
c3fca49
Rephrase the `.cargo/` entry so its first clause parses
aa58e72
Move the Cranelift table's caption above it, as this file's other ten do
29d795f
Make ADR-029 use one emphasis style throughout
cdc9c02
Close the two build-standard contract gaps and document the PATH step
56ca1fa
Document the build standard in the migration guide
7de4893
Test the order records and the non-Linux variant table
812c96b
Match grouped RUSTFLAGS as contiguous sequences
leynos bedcef5
Refuse a codegen backend named in string-valued rustflags
leynos ae3a8f2
Seed the benchmark's variant order and refuse an unusable repeat count
leynos f1f5e75
Share the checked variant state between the benchmark checks
leynos 3d36578
State the Makefile reachability predicates as properties
leynos 77a6ef2
Correct the registry-install prerequisites and drop personal pronouns
leynos cb6d6d4
Model the reachability closure as a backward walk
leynos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Repository-wide Cargo defaults for the development build standard. | ||
| # | ||
| # The mold linker and the parallel `rustc` frontend are the defaults for every | ||
| # development, test, lint and typecheck build. Cargo auto-discovers this file, | ||
| # so a bare `cargo build` gets them too; there is no opt-in path and no slower | ||
| # alternative to choose. | ||
| # | ||
| # Release and coverage builds are excluded. Both are held out by assigning | ||
| # `RUSTFLAGS`, which displaces every `rustflags` table below; see "The build | ||
| # standard" in docs/developers-guide.md for the mechanism and the contracts. | ||
| # | ||
| # No codegen backend is named here, and none may be. A panic compiled by the | ||
| # Cranelift backend does not find the unwind handler it should: `catch_unwind` | ||
| # fails to catch and a panic on a spawned thread aborts the process, while a | ||
| # bare `#[should_panic]` still passes. That makes the backend unusable for a | ||
| # profile any test or binary runs on. The guide records the measurement and the | ||
| # command; a contract refuses a backend key so that re-adding one has to go | ||
| # through that evidence first. | ||
|
|
||
| # Cargo selects a single rustflags source rather than merging them: a matching | ||
| # `[target.*]` table replaces `[build] rustflags` outright, and an externally | ||
| # set `RUSTFLAGS` replaces both. Every flag that must survive therefore has to | ||
| # be repeated in each source, including the `RUSTFLAGS` the Makefile composes | ||
| # for the gate targets. tests/build_tools_cargo_config_tests.rs and | ||
| # tests/makefile_test_target/rustflags.rs hold the sources equal. | ||
| [build] | ||
| rustflags = ["-Zthreads=8"] | ||
|
|
||
| # mold ships for Linux only, so the linker flag is gated behind a target `cfg`. | ||
| # macOS and Windows fall through to `[build] rustflags` above and use their | ||
| # platform default linker. | ||
| [target.'cfg(target_os = "linux")'] | ||
| rustflags = ["-Zthreads=8", "-Clink-arg=-fuse-ld=mold"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.