Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
Reviewer's GuideThis documentation-only PR proposes semantic compiler and application-boundary hardening, layered architecture enforcement, and a separately gated Paralegal experiment, delivered through phases 26–29 with explicit acceptance criteria, dependencies, coverage checks, and stopping rules; it adds and indexes three RFCs, three ADRs, and the continuation roadmap without changing runtime code or CI. Sequence diagram for the gated Paralegal compatibility experimentsequenceDiagram
participant Reviewer
participant Trial as P0 trial
participant Build as Netsuke production build
participant Analyzer as Paralegal analyzer
participant Graph as Production graph
Reviewer->>Trial: Freeze revisions, toolchain, target, features, roots
Trial->>Build: Establish ordinary production build
Build-->>Trial: Build result and compiler identity
Trial->>Analyzer: Check compiler-driver compatibility
Analyzer-->>Trial: Provisioned analyzer and actual analysis compiler
Trial->>Graph: Extract production roots and symbols
Graph-->>Trial: Non-empty graph and path coverage
Trial->>Graph: Repeat extraction
Graph-->>Trial: Reproducible extraction result
Trial-->>Reviewer: compatible, incompatible, or inconclusive
alt incompatible or inconclusive
Reviewer-->>Trial: Stop later gates
else compatible
Reviewer-->>Trial: Authorize at most two policy pilots
end
Flow diagram for layered architecture enforcementflowchart TD
SRC[First-party Rust sources] --> INV[Source inventory and coverage]
INV --> ANA[Bounded dependency analysis]
ANA --> FACTS[Origin-aware analysis facts]
FACTS --> POLICY[Policy evaluation and exception ledger]
POLICY --> REPORT[Deterministic diagnostics]
REPORT --> GATE[Qualified architecture gate]
GATE -->|violations or incomplete coverage| FAIL[Fail enforcement]
GATE -->|compliant and covered| PASS[Pass enforcement]
Flow diagram for Paralegal experiment gatesflowchart TD
P0[P0: required-toolchain compatibility] -->|incompatible or inconclusive| STOP[Stop and record outcome]
P0 -->|compatible production analysis| P1[P1: qualify up to two semantic policies]
P1 --> P2[P2: verify coverage, reproducibility, and cost]
P2 --> SHADOW[P3: shadow ten representative changes]
SHADOW --> DECIDE[Retain, defer, or reject]
DECIDE -->|retain| APPROVAL[Separate approval for blocking adoption]
DECIDE -->|defer or reject| CLEANUP[Retain evidence and remove unused tooling]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add three proposed RFCs, three proposed ADRs, and a roadmap continuation for the initial hexagonal hardening and architectural checking programme. The roadmap contains four phases (26–29), 13 steps, and 32 unchecked implementation tasks, each with acceptance criteria and dependencies.
Index all seven new documents in
docs/contents.mdwithout deleting or rewriting existing entries.Paralegal: compatibility before policy work
The first executable task is 29.1.2, following preregistration in 29.1.1: establish whether Paralegal can actually analyse the real production implementation using Netsuke's required Rust toolchain.
Source inspection found Netsuke on
nightly-2026-08-23and the inspected Paralegal revision onnightly-2026-04-20. This is recorded as a risk, not an executed compatibility result. The experiment's status is not run.P0 requires an ordinary production build, actual analysis-compiler identity, a non-empty graph containing independently specified production roots/symbols, and repeatable extraction. A toy, copied implementation, excluded relevant feature, old-compiler borrowing workaround, or Netsuke compiler downgrade cannot count as success. Incompatible or inconclusive outcomes stop later gates; an upstream analyser port requires a separate proposal.
Only a compatible configuration proceeds to at most two policy pilots: resolved-recipe flow and accepted redirect-target flow. Each retained policy needs six seeded violations, three legitimate controls, two reviewer-selected hold-out violations, complete declared coverage, and a demonstrated regression caught beyond existing types, structural rules, and tests.
Record provisioning/extraction/policy costs separately, use pinned cached tooling, and stay within the proposed 4-vCPU/8-GiB build/analysis and 1-vCPU/2-GiB report limits. Proposed trial ceilings are 30 minutes for P0 provisioning plus first extraction, then 15 minutes cold and 3 minutes warm for a provisioned suite. These are reviewable experimental ceilings, not measured performance claims. Ten representative shadow changes precede an explicit retain/defer/reject decision. Blocking adoption requires separate approval.
Scope and sequencing
Review order
Start with RFC 0026, then RFC 0027, and RFC 0028. Each links its narrower decision record. The roadmap supplies delivery and stopping criteria.
Validation and limitations
mainbefore publication; the inspected baseline remains79545e124b4a13dbe8352fd23df97619a91a0b5c.make check-fmt,make markdownlint,make nixie, Rust lint/test gates, or the Paralegal compatibility experiment. The required repository tools/toolchain are unavailable in this editing environment. The custom static checks do not substitute for those gates.This PR is a draft pending repository validation and design review.
Summary by Sourcery
Establish a proposed roadmap for strengthening semantic and application boundaries, enforcing architectural contracts, and evaluating Paralegal only through a bounded compatibility-first experiment.
New Features:
Enhancements:
Documentation:
Tests: