Repository navigation
fix(navigation): let the bundled app load in release builds - #163
Merged
Merged
Conversation
Tauri loads the bundled frontend at `tauri://localhost` with no trailing slash. `tauri:` is not a special URL scheme, so that URL's path is empty rather than "/", and the navigation guard blocked the app's own start page, leaving a blank white window. Dev builds were unaffected because the Vite dev server URL is http and normalizes to "/". Accept the empty path on the app origin and cover it with a test. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After installing the latest release, markpad opens to a blank white window.
The navigation guard added in #160 (
08c0909) only lets the main window show the app origin at path/or/index.html. Tauri loads the bundled frontend attauri://localhost— no trailing slash — and becausetauri:is not a special URL scheme,Url::path()is"", not"/". The guard classified the app's own start page asBlocked.Dev builds were unaffected: the Vite dev URL is
http://localhost:1420, which normalizes to/. The existing test usedtauri://localhost/(with slash), so it passed too.Fix
classify.tauri://localhost(failed before the fix withleft: Blocked, right: App).Testing
cargo test --lib— 6 passedcargo clippy --all-targets— cleannpm run tauri buildoutput launches before cutting the patch release.🤖 Generated with Claude Code