Skip to content

fix(android): head gestures don't answer or decline calls #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jeremy0538 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): head gestures don't answer or decline calls #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions android/app/src/main/java/me/kavishdevar/librepods/utils/GestureDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class GestureDetector(
private const val MAX_REQUIRED_EXTREMES = 4

private const val MAX_VALID_ORIENTATION_VALUE = 6000
private const val SLOW_SAMPLE_INTERVAL_MS = 100
}

val audio = GestureFeedback(ServiceManager.getService()?.baseContext!!)
Expand Down Expand Up @@ -91,6 +92,7 @@ class GestureDetector(

private var significantMotion = false
private var lastSignificantMotionTime = 0L
private var lastSampleAt = 0L

init {
while (horizontalAvgBuffer.size < 3) horizontalAvgBuffer.add(0.0)
Expand Down Expand Up @@ -180,8 +182,14 @@ fun startDetection(doNotStop: Boolean = false, onGestureDetected: (Boolean) -> U
prevHorizontal = horizontal.toDouble()
prevVertical = vertical.toDouble()

val smoothHorizontal = applySmoothing(horizontal.toDouble(), horizontalAvgBuffer)
val smoothVertical = applySmoothing(vertical.toDouble(), verticalAvgBuffer)
// During a call the AirPods send head tracking at ~5 Hz instead of ~25 Hz. At that rate
// consecutive samples land on opposite sides of a nod, and averaging three of them
// cancels the motion out, so no peak ever passes peakThreshold. Use raw values then.
val now = System.currentTimeMillis()
val slowSamples = lastSampleAt > 0 && now - lastSampleAt > SLOW_SAMPLE_INTERVAL_MS
lastSampleAt = now
val smoothHorizontal = if (slowSamples) horizontal.toDouble() else applySmoothing(horizontal.toDouble(), horizontalAvgBuffer)
val smoothVertical = if (slowSamples) vertical.toDouble() else applySmoothing(vertical.toDouble(), verticalAvgBuffer)

synchronized(horizontalBuffer) {
horizontalBuffer.add(smoothHorizontal)
Expand Down Expand Up @@ -410,6 +418,7 @@ fun startDetection(doNotStop: Boolean = false, onGestureDetected: (Boolean) -> U
lastPeakTime = 0
significantMotion = false
lastSignificantMotionTime = 0L
lastSampleAt = 0L
}

private fun Double.pow(exponent: Int): Double = this.pow(exponent.toDouble())
Expand Down