Repository navigation
ci: cross-platform CI manual-only on dev (drop dev push); document CI policy - #7057
Conversation
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
chore
⏳ DRAFT
What to do
Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c423ad2ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - '.github/workflows/codex-queue-helpers.yml' | ||
| push: | ||
| branches: [dev, main, preview] | ||
| branches: [main, preview] |
There was a problem hiding this comment.
When a pull request changes any path selected by this workflow, offline-helpers still expands the unconditional three-OS matrix at lines 35-41, so macOS and Windows jobs continue to run on pull_request; removing the dev push trigger and adding manual dispatch therefore does not implement the new Ubuntu-only PR policy. Make the matrix event-dependent—Ubuntu for pull requests and all three platforms for push/dispatch—and add a workflow contract assertion for it.
AGENTS.md reference: AGENTS.md:L370-L374
Useful? React with 👍 / 👎.
| # * Full cross-platform (macOS/Windows) CI runs ONLY via manual | ||
| # workflow_dispatch and on push to main/preview (release lines). |
There was a problem hiding this comment.
The statement that cross-platform CI runs only through manual dispatch or main/preview pushes contradicts this workflow's retained schedule at lines 79-92: the scheduled run explicitly selects the full matrix, resolves a dev SHA, and both platform-macos and platform-windows accept the schedule event. Consequently cross-platform testing of dev is still automatic every night, not manual-only; either document the nightly exception consistently here, in AGENTS.md, and in CONTRIBUTING.md, or remove the scheduled cross-platform execution if the new policy is intended literally.
AGENTS.md reference: AGENTS.md:L370-L374
Useful? React with 👍 / 👎.
1 participant
Maintainer decision (Jun): PRs run only the fast Ubuntu subset. Full cross-platform (macOS/Windows) CI runs only via manual workflow_dispatch and main/preview push. Removes dev from push branches in ci.yml, service-lifecycle.yml, catalog-async-contracts.yml, codex-queue-helpers.yml (adds workflow_dispatch to codex-queue-helpers). Policy documented in AGENTS.md, CONTRIBUTING.md and a ci.yml header; PRs that re-add dev push or PR macOS/Windows runs will be closed. Updates contract tests from #7052. tests/ci-workflows: 1530 pass; 6 pre-existing env failures identical on dev.