Repository navigation
test(responses): register combo-tool-loop-pin in the core module inventory - #7357
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Fixes the
devCI regression from #7354 (f7bdd8e). In run 39212576911, Linuxtest 2/4andmacos 2/3failedtests/responses/responses-core-modules.test.ts› "every extracted owner is covered and remains below 2000 physical lines".#7354 moved the combo tool-loop pin out of
core-combo.tsintosrc/server/responses/combo-tool-loop-pin.ts. That file is now part of the owner graph walked fromcore.ts, but it was never added to the source inventory. This PR adds it toRESPONSES_CORE_MODULESintests/helpers/responses-core-source.ts, right after the other combo owners, with the same kind of "Reached from core-combo.ts" note as its neighbors.It is an extracted owner and not a separate boundary:
core-combodelegates the initial pick to it, and it imports onlycombo-session-recall.ts, which is already inEXISTING_BOUNDARIES. No runtime code changes.I also checked the other inventories against the files #7354 and #7355 added (
combo-tool-loop-pin.ts, three test files,structure/transports/responses-combo-boundaries.md). The test layout (layout.jsonplus expected fixture), the structure manifest and index, the file-size ratchet and the Lab core boundary already cover them. The pin keeps no state of its own, so the state-store sweeper inventory does not apply.Verification
bun test tests/responses/responses-core-modules.test.ts: 10 pass / 0 fail (failed ondev).bun scripts/test.ts tests/responseswith Bun 1.4.3 (OCX_TEST_RUNNER_BUN): 6095 pass / 0 fail / 1 skip across 271 files.bun scripts/test.tswith Bun 1.4.3 on the guard files: 167 pass / 0 fail. Files:test-layout,test-layout-tooling,file-size-ratchet,structure-ssot,repo-hygiene,core-lab-boundary,state-store-sweeper, and the three fix(combos): keep tool loops on one target and make failover history safe (#7298) #7354 tests.bun run typecheck,bun run structure:check,bun run privacy:scan: pass.tests/responsesdirectory that consumes it passes.Checklist
Summary by CodeRabbit