Skip to content

test(responses): register combo-tool-loop-pin in the core module inventory - #7357

Merged
lidge-jun merged 1 commit into
devfrom
test/register-combo-tool-loop-pin
Oct 19, 2026
Merged

lidge-jun merged 1 commit into
devfrom
test/register-combo-tool-loop-pin

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes the dev CI regression from #7354 (f7bdd8e). In run 39212576911, Linux test 2/4 and macos 2/3 failed tests/responses/responses-core-modules.test.ts › "every extracted owner is covered and remains below 2000 physical lines".

#7354 moved the combo tool-loop pin out of core-combo.ts into src/server/responses/combo-tool-loop-pin.ts. That file is now part of the owner graph walked from core.ts, but it was never added to the source inventory. This PR adds it to RESPONSES_CORE_MODULES in tests/helpers/responses-core-source.ts, right after the other combo owners, with the same kind of "Reached from core-combo.ts" note as its neighbors.

It is an extracted owner and not a separate boundary: core-combo delegates the initial pick to it, and it imports only combo-session-recall.ts, which is already in EXISTING_BOUNDARIES. No runtime code changes.

I also checked the other inventories against the files #7354 and #7355 added (combo-tool-loop-pin.ts, three test files, structure/transports/responses-combo-boundaries.md). The test layout (layout.json plus expected fixture), the structure manifest and index, the file-size ratchet and the Lab core boundary already cover them. The pin keeps no state of its own, so the state-store sweeper inventory does not apply.

Verification

  • bun test tests/responses/responses-core-modules.test.ts: 10 pass / 0 fail (failed on dev).
  • bun scripts/test.ts tests/responses with Bun 1.4.3 (OCX_TEST_RUNNER_BUN): 6095 pass / 0 fail / 1 skip across 271 files.
  • bun scripts/test.ts with Bun 1.4.3 on the guard files: 167 pass / 0 fail. Files: test-layout, test-layout-tooling, file-size-ratchet, structure-ssot, repo-hygiene, core-lab-boundary, state-store-sweeper, and the three fix(combos): keep tool loops on one target and make failover history safe (#7298) #7354 tests.
  • bun run typecheck, bun run structure:check, bun run privacy:scan: pass.
  • I did not run the full suite locally. Only one test helper changed, and the whole tests/responses directory that consumes it passes.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (None needed: test inventory only.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (No runtime, auth or logging change.)

Summary by CodeRabbit

  • Tests
    • Expanded automated test coverage to include tool-loop continuation scenarios alongside the core response modules. This update affects test coverage only; it does not change app behavior or add user-facing functionality. The additional coverage helps ensure these continuation scenarios are included in future checks of core response behavior.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 19, 2026 07:16
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Oct 19, 2026
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 3d198487-d094-43c9-9c68-d0977a6aa942
📥 Commits

Reviewing files that changed from the base of the PR and between 718692b and 66d6d96.

📒 Files selected for processing: 1
  • tests/helpers/responses-core-source.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The test helper source inventory now includes combo-tool-loop-pin.ts. A comment links it to tool-loop continuations from core-combo.ts.

Changes: Responses core source inventory

Layer / File(s) Summary
Update source inventory
tests/helpers/responses-core-source.ts
Adds combo-tool-loop-pin.ts to RESPONSES_CORE_MODULES and documents its connection to core-combo.ts tool-loop continuations.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 66d6d

This change updates test inventory coverage without changing runtime behavior. No actionable merge risk is evident beyond normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: registering combo-tool-loop-pin in the Responses core module inventory.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T07:18:12.189283Z 66d6d96 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun merged commit 7ec6221 into dev Oct 19, 2026
32 checks passed
@lidge-jun
lidge-jun deleted the test/register-combo-tool-loop-pin branch October 19, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant