Repository navigation
feat(usage): extend opt-in cache continuation diagnostics - #7479
yuanyuanlove wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. Hygiene✅ Deterministic PR hygiene checks passed. |
|
Independent source review (gpt-6.1-sol, dispatched by the triage manager, 2026-10-24) at head VERDICT: MUST-FIX Reviewed head:
Readiness: exact-head CI is Static inspection: template complete; test registration present in both maps; layout 1,999 lines, structure doc 600; no changed-file ratchet violation. No introduced Windows-specific sensitivity warrants mandatory NOT RUN: tests, typecheck, builds, or validation gates, as requested. This is a read-only source review; merging still requires the gates named above (exact-head CI, |
Carry the existing admission principal through the private diagnostic hook instead of deriving caller scope from rewritten Authorization headers. Preserve the original PR history and incorporate current dev for validation.
Summary
OPENCODEX_CACHE_DEBUGdiagnostics with bounded continuation/prefix comparisons, independent session-header observations, and explicitly derived (not proven) affinity-key comparisons. No routing, cache-behavior or performance change is claimed.uncomparable; per-request inbound/outbound comparisons still work. Raw credentials are never used as diagnostic history keys.devatceef4889e4666dc0492a375d272eafa5b785361e. The resulting PR diff is limited to the diagnostics enhancement and this identity fix (11 files); no cache-evidence changes from fix(usage): preserve source-aware cache evidence across attempts #7485 are included.Verification
Validated head:
bffa47bed782a5ca7454a3301f776e68cae61e82(tree27a118e083171b916aa108706abcf5a7fee22599). All work ran in an isolated Linux cloud workspace. Tests use synthetic callers and provider responses; the focused integration fixtures assert zero external network calls.aa3e7fdb0620cec0fa1b72161b005719a0acc781: the new 17-case integration suite had 2 passing authentication-refusal controls and 15 failing history-isolation regressions. All 17 pass after the fix, including after incorporating current dev.tests/usage/cache-diagnostic.test.ts(34),cache-diagnostic-caller-isolation.test.ts(17),cache-diagnostic-hook-compat.test.ts(10), andtests/responses/protocol-antigravity-direct-eligibility.test.ts(19): 80 passed.bun run typecheck,bun run privacy:scan,bun run structure:check, andgit diff --checkpassed. Independent read-only review found no remaining actionable issue.bun test tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/lab/core-lab-boundary.test.ts: 61 passed, no caps raised.--versionsmoke returnedopencodex 2.93.0. This is not a GUI/release-package build.ASTRO_TELEMETRY_DISABLED=1 OPENCODEX_DOCS_OFFLINE=1 bun run build: 593 pages and 84,861 internal links checked.Remaining coverage:
bun run test:changedwas blocked by the validation environment's network policy when it attempted an external Google Cloud endpoint; it was not retried or treated as a passing suite. Full-suite, packaged GUI and native macOS/Windows validation were not run. This uses the repository's documented focused-validation scope exception. Keep this Draft pending exact-head CI approval/execution and maintainer privacy/diagnostic-contract review.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.