Repository navigation
Conversation
…uncher arch anchor
…the shim interpreter
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Align the seven locale summaries (fr, ja, ko, ru, tr, zh-cn, zh-tw) in cli.md and cli/agents.md with the English contract: the held-bound Node/npm toolchain is prefix-local when present, otherwise the captured-PATH pair anchored to the launcher architecture; a managed Windows result classifies the observed installation layout only and does not guarantee which interpreter a later codex.cmd resolves; PATH-only selection, OpenCodex autostart wrappers, and global/vendor fallback stay deferred with apply disabled.
luvs01
marked this pull request as draft
October 24, 2026 07:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows read-only planning currently refuses standard npm installations when
codex.cmdand Node/npm live in separate prefixes. This change binds the Node/npm pair resolved from the trusted launcher's captured PATH as the updater's metadata toolchain when prefix-local Node is proven absent and the launcher architecture matches the observed Node PE architecture.This deliberately expands the supported read-only contract. It does not attest the interpreter a future
codex.cmdinvocation will resolve: CMD can prefer that invocation's working directory. Documentation distinguishes installation-layout classification (managed) from interpreter or write authority. Windows apply remains disabled in this PR.Stacked on #7596 at refreshed head
f7e55ab0. Explicit candidate selection, denied/reparse-versus-missing handling, held file identities, revalidation, isolated metadata queries and backing-package checks remain in place. The content-proof domain is v3. The parent's opt-in content observation and handles held across asynchronous resolution are preserved. Seven translated locale summaries now match this supported-layout contract.Verification
6b723008cc945cccabd0e7af0947fb6e6f531e64is a normal-merge composition of original head3407e5f6and refreshed parentf7e55ab0(currentdevplus the shared Bun 1.4.4 baseline from chore(test): align Bun runner with the 1.4.4 security baseline #7627), plus the shared one-row CI duration-table correction.bun test --isolate --timeout 60000:tests/codex-integration/codex-cli-windows-plan.test.ts18 passed / 0 failed / 108 assertions, including the published Node CLI production-inspector metadata case. Roottsc --noEmit, structure SSOT, skill-surface and scoped static checks all exited 0.devonlytestRunnerBunchanges to 1.4.4.bc08a484), which contains this change, passed 510 tests / 64 platform skips / 0 failures / 2,911 assertions across 18 units on the same validation.Checklist