Repository navigation
Conversation
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
luvs01
marked this pull request as ready for review
October 23, 2026 11:21
2 of 3 tasks
luvs01
marked this pull request as draft
October 24, 2026 06:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a read-only verifier for Windows x64 Codex CLI archives and the expected installed layout. It checks main/backing package linkage, the
codex.exePE header, Windows path ambiguity, three supported npm shims, and the relative path, size and digest of every expected package file.Windows tar checks are opt-in. The native header comes from the same verified stream with at most 4 KiB of extra buffering. The result explicitly carries
applicable: falseandmutationAuthority: false; there is no apply consumer.Stacked on #7596 at refreshed head
f7e55ab0. This is one part of #2811.Limits
Supports x64, ASCII archive paths, sibling backing packages and the specified node-shebang shim grammar. PE header sanity is not signature, loadability or execution proof. Byte equality does not establish prefix ownership, selection or write authority. Real npm installation and native acceptance remain unverified.
Verification
29f3d2c5cbbb6423fdba23f04334edac14cca747is a normal-merge composition of original headaa396701and refreshed parentf7e55ab0(currentdevplus the shared Bun 1.4.4 baseline from chore(test): align Bun runner with the 1.4.4 security baseline #7627), plus the shared one-row CI duration-table correction. The Windows layout/path verifiers and their fixtures/tests are unchanged.bun test --isolate --timeout 60000:tests/codex-integration/codex-cli-update-windows-layout.test.ts40 passed / 0 failed / 69 assertions. Roottsc --noEmit, structure SSOT, skill-surface and scoped static checks all exited 0.devonlytestRunnerBunchanges to 1.4.4.bc08a484), which contains this change, passed 510 tests / 64 platform skips / 0 failures / 2,911 assertions across 18 units on the same validation.Checklist