fix(widget): preserve refund status and transaction hashes in history - #888
Open
BiscuitCoder wants to merge 1 commit into
Open
BiscuitCoder wants to merge 1 commit into
BiscuitCoder wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 0015fd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BiscuitCoder
force-pushed
the
codex/preserve-refund-history
branch
from
September 29, 2026 15:16
2342576 to
0015fd2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
No Linear task; this is an external bug-fix contribution.
Why was it implemented this way?
Transaction history currently discards the API's
substatusandsubstatusMessage. ADONE / REFUNDEDtransfer is reconstructed asCOMPLETED, soisRouteRefundedreturns false. When the refund returns to the source chain, the same-chain shortcut also collapses the sending and receiving transactions into oneSWAPaction, losing the refund transaction hash and link.Preserve the reported substatus and explanation, retaining the existing defaults when they are absent. Exclude refunds from the same-chain shortcut so both transactions remain available. This also preserves
PARTIALoutcomes for the existing partial-completion detection. Ordinary same-chain swaps keep their single action.The production change is limited to four substitutions in the history converter. No new dependencies or public API changes. Includes a patch changeset for
@lifi/widget.Validation:
changeset statuspassed.Visual showcase (Screenshots or Videos)
Deterministic converter regression, using synthetic history data:
DONE / REFUNDED, both transactions on chain 1SWAP / COMPLETEDaction, source hash onlyCROSS_CHAINandRECEIVING_CHAIN / REFUNDEDactions, source and refund hashesDONE / PARTIALCOMPLETEDPARTIAL, with the API explanationNo visual components were changed.
Checklist before requesting a review