Repository navigation
move focus hold clearing to top of key up handler - #812
Merged
michielvandergeest merged 2 commits intoOct 22, 2026
Merged
michielvandergeest merged 2 commits into
michielvandergeest merged 2 commits into
Conversation
Test Results: ✅ PASSEDRun at: 2026-10-20T20:12:15.527Z Summary: |
il-sairamg
self-requested a review
October 22, 2026 08:47
il-sairamg
approved these changes
Oct 22, 2026
il-sairamg
left a comment
il-sairamg
left a comment
Collaborator
There was a problem hiding this comment.
Approach looks good to me — resetting Focus.hold before running the callback is the right call, since the key is already released and hold should clear regardless of what the callback does.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a callback in the key up handle throws an error the Focus hold state is never reset, which can be a problem.
In this PR I changed to do it in the beginning before doing the callback, so it can not interfere and is alwyas set back to false.
It was the easiest way I could think. Please let me know if this is the good way to do it