Repository navigation
Cache computed properties with lazy dirty-checking - #819
Open
wouterlucas wants to merge 1 commit into
Open
wouterlucas wants to merge 1 commit into
wouterlucas wants to merge 1 commit into
Conversation
Evaluate each computed at most once per dependency change instead of on every read, porting Vue2's lazy computed watcher semantics. - Per-instance WeakMap caches (setup runs per type, getters run per instance); first read evaluates, later reads return the cache - Evaluation runs under withTracking so deps subscribe an invalidator that marks dirty and notifies downstream readers on change - Invalidators register in instance effects so destroy unsubscribes them - effect(): extracted withTracking helper, no behavior change
Benchmark comparison
Negative means faster. Informational results; small changes can be measurement noise. Head: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #818 (needs its scheduler). Evaluates each computed at most once per dependency change instead of on every read, porting Vue2's lazy computed-watcher semantics.
What changed:
src/component/setup/computed.js: per-instanceWeakMapcaches (setup runs per type, getters run per instance). First read evaluates; later reads return the cache and subscribe the reader viatrack(entry, 'value').withTrackinghelper so deps subscribe a per-entry invalidator that marksdirtyand notifies downstream on change (chained computeds propagate through the same mechanism).symbols.effectssodestroy()unsubscribes them; plain-object test doubles skip registration.src/lib/reactivity/effect.js: extractedwithTracking(effectFn, key, fn);effect()is a thin wrapper, no behavior change.Dynamic updatestest now uses reactive backing (plain writes cannot invalidate any cache — same as Vue); new tests pin single evaluation, chain invalidation, multi-dep batching (1 recompute + 1 downstream run), and per-instance isolation.Verification: eslint clean, full suite 1546/1546 pass.