Fall back to p2p gossip on signet when no RGS URL is configured#87
Fall back to p2p gossip on signet when no RGS URL is configured#87hash-money wants to merge 1 commit into
Conversation
With neither RGS nor p2p configured, a signet wallet has an empty network graph and can only pay route-hinted invoices — anything from a node with an announced channel fails with RouteNotFound before an HTLC is dispatched. No public RGS server exists for arbitrary signets, and small deployments (LSP + mint + wallets) often never propagate their announcements into any public graph, so even Mutinynet's RGS cannot teach a wallet its own island's topology. P2P gossip from the wallet's peers (its LSP) provides exactly the local topology it needs, matching the existing regtest behavior; an explicitly configured rgs_url still takes precedence. Fixes lightningdevkit#86
benthecarman
left a comment
There was a problem hiding this comment.
is this actually an issue? We should default to p2p gossip if no rgs url is set
|
You're right — closing, and thanks for the pushback. I'd missed that ldk-node's builder defaults an unset gossip source to p2p ( Verified empirically against our signet deployment to make sure: a fresh node built with no gossip-source call, connected to our LSP, learns the island's announced channel via p2p in ~15s (the leaf sends One small suggestion: the explicit |
Fixes #86.
On signet with no
rgs_urlconfigured, the gossip-source match falls through to an empty arm, leaving the wallet with no network graph at all — it can only pay invoices whose route hints bridge from its own LSP channels, and anything from a node with an announced channel fails instantly withRouteNotFound.This falls back to
set_gossip_source_p2p()on signet, matching the existing regtest behavior. The wallet's peers are exactly its LSP (and whatever the LSP talks to), so p2p gossip teaches it precisely the local topology it needs; signet graphs are small enough that sync cost is negligible. An explicitly configuredrgs_urlstill takes precedence.Why not RGS: no public RGS server exists for arbitrary signets, and even on Mutinynet a small LSP+mint deployment may never reach the public graph — we verified this empirically before proposing the p2p route: opened an announced bridge channel from our mint to Mutinynet's best-connected public node, watched the first-party channel get indexed within the hour, and watched our third-party mint↔LSP announcement never propagate over 15+ hours (funding UTXO unspent, valid signatures — the relaying node simply doesn't forward leaf-peer third-party gossip). Details and timed on-device repro in #86 and the linked downstream issue.