Skip to content

Add provider-neutral agent feedback workflow - #22

Draft
angusbezzina wants to merge 6 commits into
mainfrom
angus/agentic-enhancements
Draft

Add provider-neutral agent feedback workflow#22
angusbezzina wants to merge 6 commits into
mainfrom
angus/agentic-enhancements

Conversation

@angusbezzina

@angusbezzina angusbezzina commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Margin comments can now drive coding-agent edits without a generated inbox or provider integration. A user marks an unresolved thread For agent, then copies one/selected/all comments or lets any shell-capable host read the same local source context through attn feedback and attn feedback --watch.

The implementation adds:

  • private, versioned native and browser routing for For-agent marks while preserving human authorship and shared review events;
  • Markdown and HTML composer/thread controls plus direct Copy, Copy selected and Copy all actions with file/project scope and clipboard fallback;
  • a deterministic feedback projection with stable room/thread/file IDs, ordered conversation, explicit source availability, current anchor resolution, and separate feedback/source revisions;
  • offline readable and JSON snapshots from attn feedback [PATH];
  • a flushed NDJSON daemon stream from attn feedback --watch [PATH] with complete snapshots, upserts, removals, resets, disconnect errors, and closed-pipe cleanup;
  • provider-neutral host instructions, a minimal stream adapter, updated interactive artifact, and implementation evidence.

Agents edit the original source with their existing permissions. Reading, copying, and watching leave the review thread open and never run a model or post a reply. Native marks are available to the local CLI; browser-only marks remain private to that browser. Cross-device mark sync, browser-to-local pairing, and private comments on unshared documents remain outside this change.

Validation:

  • cargo fmt --all -- --check
  • cargo test --workspace --locked --quiet — all Rust suites passed, including feedback CLI subprocess and review convergence tests
  • npm run check in web/ — 0 errors and 0 warnings
  • npm test in web/ — all 144 test files passed
  • npm run build and npm run build:browser in web/ — passed; existing mixed-import and large-chunk warnings remain
  • node --check examples/feedback-watch.mjs
  • live disposable-fixture exercises with Codex CLI 0.153.4 and Claude Code 2.1.263: each received a later human revision, edited the bound source, and observed source_changed; provider-free watch delivery measured 209.4 ms

Implementation evidence: planning/collab/agent-feedback-implementation-evidence.md. Beads epic attn-aysu and all 24 leaf tasks are closed and pushed.

@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
attn Ready Ready Preview Sep 7, 2026 8:28pm UTC

Request Review

@angusbezzina angusbezzina changed the title Plan agent feedback with snapshot and watch commands Add provider-neutral agent feedback workflow Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant