fix(cli): recover unescaped quotes in JSON repair step#2136
Draft
maxprilutskiy wants to merge 1 commit into
Draft
fix(cli): recover unescaped quotes in JSON repair step#2136maxprilutskiy wants to merge 1 commit into
maxprilutskiy wants to merge 1 commit into
Conversation
Escape unescaped double quotes in model translation responses when jsonrepair fails, then retry — avoiding a costly fallback retranslation. Generated with [Linear](https://linear.app/lingodotdev/issue/ENG-609/processlocalize-fix-unescaped-quotes-in-the-json-repair-step-to-save#agent-session-95da1f6b) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover from unescaped double quotes in model translation responses so they no longer trigger a costly fallback retranslation.
Changes
escapeUnescapedQuotespass inmodel-response.tsthat runs only whenJSON.parseandjsonrepairboth fail. It scans the string, treating a"as a real terminator only when followed by a structural delimiter (:,,,},]) or end-of-input, and escaping any other in-string quote before retryingjsonrepair. Claude Sonnet occasionally emits values like"She said "hi" and "bye""that plainjsonrepaircan't recover.Testing
Business logic tests added:
parseModelResponserecovers a value with multiple unescaped quotesparseModelResponserecovers a trailing unescaped quote at the end of a valueescapeUnescapedQuotesleaves already-escaped quotes and valid JSON untouchedChecklist