Conversation
Backport upstream commit 4671c6a to 0.6.
Collaborator
|
It should be cherry picked if you want it backported but in any case, 0.6 release was not ready in any mean, you should bump to 0.7.0-beta, the stable release will be done in few days |
5 of 13 tasks
Author
|
Thanks for the heads-up! Closing this since 0.7.0 stable is releasing soon, so we will bump to 0.7.0 then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports commit 4671c6a to the 0.6 branch.
Right now on 0.6, unlocking or locking
/org/freedesktop/secrets/aliases/defaultspams:WARN oo7_daemon::service: Object: /org/freedesktop/secrets/aliases/default does not exist.This happens because
set_lockedcompares literal object paths instead of resolving aliases first, and the warn log sits inside the collection loop.Backports
resolve_aliasintoset_lockedand moves the warning outside the loop, matching what is on main.